Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPA Lint #616

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix SPA Lint #616

merged 1 commit into from
Sep 4, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Fixes failing lint on the trunk branch.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added Code Review The PR is in Code Review Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review labels Sep 2, 2024
@arunshenoy99 arunshenoy99 merged commit 1d995c9 into trunk Sep 4, 2024
6 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/spa-lint branch September 4, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants