Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Onboarding and related dependencies #718

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Sep 11, 2024

Proposed changes

Onboarding:

  1. Fix Failing Onboarding Test wp-module-onboarding#614
  2. Fix SPA Lint wp-module-onboarding#616
  3. Fix header Menu in DIY flow when Primary and Secondary Type are not selected wp-module-onboarding#611
  4. Fix Onboarding Flow GET Error wp-module-onboarding#612
  5. Upgrade to Theme Customizations Instead of Child Themes wp-module-onboarding#613
  6. Add Migration Event Tests wp-module-onboarding#617
  7. Disable Sentry During Cypress Tests Run wp-module-onboarding#618

Onboarding Data:

  1. added header and footer mapping in fallback wp-module-onboarding-data#110
  2. Update README.md wp-module-onboarding-data#109
  3. Helper Functions and Slugs for Interacting with Flow and Theme Data wp-module-onboarding-data#111

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Sep 11, 2024

HostGator Plugin    Run #4868

Run Properties:  status check passed Passed #4868  •  git commit 797d1f8252 ℹ️: Merge 50559829d4c88fcb08086f42e8606a53e26db1ea into c3fe19807038bc65e8070bcb0d9b...
Project HostGator Plugin
Branch Review bump/onboarding
Run status status check passed Passed #4868
Run duration 25m 34s
Commit git commit 797d1f8252 ℹ️: Merge 50559829d4c88fcb08086f42e8606a53e26db1ea into c3fe19807038bc65e8070bcb0d9b...
Committer Arun Shenoy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@wpscholar wpscholar added this to the September 25 Release milestone Sep 18, 2024
@wpscholar wpscholar self-requested a review September 18, 2024 14:39
@wpscholar wpscholar changed the base branch from develop to release/2.11.6 September 18, 2024 17:13
@wpscholar wpscholar merged commit a6612d3 into release/2.11.6 Sep 18, 2024
@wpscholar wpscholar deleted the bump/onboarding branch September 18, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants