Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Onboarding and related dependencies #1306

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Bump Onboarding and related dependencies #1306

merged 10 commits into from
Sep 17, 2024

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Sep 11, 2024 •
edited by officiallygod
Loading

Proposed changes

Onboarding:

  1. Fix Failing Onboarding Test newfold-labs/wp-module-onboarding#614
  2. Fix SPA Lint newfold-labs/wp-module-onboarding#616
  3. Fix header Menu in DIY flow when Primary and Secondary Type are not selected newfold-labs/wp-module-onboarding#611
  4. Fix Onboarding Flow GET Error newfold-labs/wp-module-onboarding#612
  5. Upgrade to Theme Customizations Instead of Child Themes newfold-labs/wp-module-onboarding#613
  6. Add Migration Event Tests newfold-labs/wp-module-onboarding#617
  7. Disable Sentry During Cypress Tests Run newfold-labs/wp-module-onboarding#618
  8. Fix Plugin Activation newfold-labs/wp-module-onboarding#621

Onboarding Data:

  1. added header and footer mapping in fallback newfold-labs/wp-module-onboarding-data#110
  2. Update README.md newfold-labs/wp-module-onboarding-data#109
  3. Helper Functions and Slugs for Interacting with Flow and Theme Data newfold-labs/wp-module-onboarding-data#111

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress Cypress
Copy link

cypress bot commented Sep 11, 2024

Bluehost Brand Plugin    Run #10351

Run Properties:  status check passed Passed #10351  •  git commit 34210e6ef0 ℹ️: Merge 9051aa427ec2a3db33990efbbbbafd0627e75fc1 into 0bbd1890f7459571095e9b75eea6...
Project Bluehost Brand Plugin
Branch Review bump/onboarding
Run status status check passed Passed #10351
Run duration 25m 59s
Commit git commit 34210e6ef0 ℹ️: Merge 9051aa427ec2a3db33990efbbbbafd0627e75fc1 into 0bbd1890f7459571095e9b75eea6...
Committer Arun Shenoy
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Sep 17, 2024 •
edited
Loading

Bluehost Brand Plugin    Run #10464

Run Properties:  status check passed Passed #10464  •  git commit 078424b087: Update package-lock.json
Project Bluehost Brand Plugin
Branch Review bump/onboarding
Run status status check passed Passed #10464
Run duration 26m 15s
Commit git commit 078424b087: Update package-lock.json
Committer Brad Parbs
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@bradp bradp mentioned this pull request Sep 17, 2024
Closed
wpscholar
wpscholar previously approved these changes Sep 17, 2024
View reviewed changes
@wpscholar wpscholar changed the base branch from develop to main September 17, 2024 20:59
@wpscholar wpscholar dismissed their stale review September 17, 2024 20:59

The base branch was changed.

@bradp bradp merged commit cfbd2b0 into main Sep 17, 2024
20 of 40 checks passed
@wpscholar wpscholar deleted the bump/onboarding branch September 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arunshenoy99 @wpscholar @bradp @officiallygod