-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRESS-2 834 Implement Site Classification API (Frontend) #221
Merged
arunshenoy99
merged 37 commits into
trunk
from
PRESS2-834-Implement-Site-Classification-API-Frontend
May 9, 2023
Merged
PRESS-2 834 Implement Site Classification API (Frontend) #221
arunshenoy99
merged 37 commits into
trunk
from
PRESS2-834-Implement-Site-Classification-API-Frontend
May 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0902969.
https://github.com/newfold-labs/wp-module-onboarding into PRESS2-834-Implement-Site-Classification-API-Frontend
Please use: #220 and newfold-labs/wp-module-data#16 to test this branch out |
arunshenoy99
changed the title
PRESS-2 834 Implement Site Cassification API ( Frontend )
PRESS-2 834 Implement Site Classification API (Frontend)
Apr 28, 2023
Added a Fallback incase the data module PR isn't merged. |
abhijitb
approved these changes
May 5, 2023
officiallygod
added
QA
This PR is in QA
and removed
Code Review
The PR is in Code Review
labels
May 5, 2023
arunshenoy99
requested changes
May 8, 2023
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/PrimarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/PrimarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/PrimarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/PrimarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/SecondarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/SecondarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/SecondarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/SecondarySite/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/SecondarySite/index.js
Outdated
Show resolved
Hide resolved
officiallygod
added
Code Review
The PR is in Code Review
and removed
QA
This PR is in QA
labels
May 8, 2023
arunshenoy99
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @officiallygod this looks much cleaner now.
officiallygod
added
QA
This PR is in QA
Ready to merge
The Code Review and QA is done and it can be merged.
and removed
Code Review
The PR is in Code Review
QA
This PR is in QA
labels
May 8, 2023
officiallygod
added
QA
This PR is in QA
and removed
Ready to merge
The Code Review and QA is done and it can be merged.
labels
May 9, 2023
…oarding into PRESS2-834-Implement-Site-Classification-API-Frontend
arunshenoy99
deleted the
PRESS2-834-Implement-Site-Classification-API-Frontend
branch
May 25, 2023 05:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the Frontend part that shows the Primary and Secondary steps from the Site Classification API
WordPress.Store.WordPress.mp4