Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS-2 834 Implement Site Classification API (Frontend) #221

Merged

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Apr 28, 2023

This branch adds the Frontend part that shows the Primary and Secondary steps from the Site Classification API

WordPress.Store.WordPress.mp4

@officiallygod
Copy link
Member Author

Please use: #220 and newfold-labs/wp-module-data#16 to test this branch out

@officiallygod officiallygod self-assigned this Apr 28, 2023
@arunshenoy99 arunshenoy99 changed the title PRESS-2 834 Implement Site Cassification API ( Frontend ) PRESS-2 834 Implement Site Classification API (Frontend) Apr 28, 2023
@officiallygod officiallygod added the Code Review The PR is in Code Review label May 2, 2023
@officiallygod
Copy link
Member Author

Added a Fallback incase the data module PR isn't merged.

@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels May 5, 2023
@officiallygod officiallygod added Code Review The PR is in Code Review and removed QA This PR is in QA labels May 8, 2023
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @officiallygod this looks much cleaner now.

@officiallygod officiallygod added QA This PR is in QA Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review QA This PR is in QA labels May 8, 2023
@officiallygod officiallygod added QA This PR is in QA and removed Ready to merge The Code Review and QA is done and it can be merged. labels May 9, 2023
@arunshenoy99 arunshenoy99 merged commit 3c9cedf into trunk May 9, 2023
@arunshenoy99 arunshenoy99 deleted the PRESS2-834-Implement-Site-Classification-API-Frontend branch May 25, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA This PR is in QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants