Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit:
SiteClassification
,PrimaryType
,SecondaryType
and an abstractTypes
class for storing code common in both classes (also gives us an opportunity to add more types if needed in the future).Data/Static/site-classification.json
when it cannot fetch data from the worker, this static data is cached only for an hour, it also adds astatic
property to the data before caching and returning it.PrimaryType
andSecondaryType
help in managing primary and secondary selections respectively, which includes validating, saving and fetching the data to/from the option.