Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update primary and secondary type data using helpers from the data module #237

Merged
merged 1 commit into from
May 9, 2023
Merged

Update primary and secondary type data using helpers from the data module #237

merged 1 commit into from
May 9, 2023

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented May 9, 2023 •
edited
Loading

This should be merged only after #221

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label May 9, 2023
abhijitb
abhijitb approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@abhijitb abhijitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arunshenoy99 arunshenoy99 merged commit 6b739e5 into trunk May 9, 2023
@arunshenoy99 arunshenoy99 deleted the add/PRESS2-114-implement-site-classification-api branch May 25, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijitb abhijitb abhijitb approved these changes

Assignees
No one assigned
Labels
Code Review The PR is in Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @abhijitb