Press 2 458 Loader for Radio label controls #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
officiallygod
added
WIP
arunshenoy99
added
Post Phase 2 Polish
There was a problem hiding this comment.
Can we separate the radio control from the actual skeleton and make them two separate components? Let me know if you need some ideas there. We also need to think of separating src/OnboardingSPA/components/LivePreview/LivePreviewSkeleton/index.js from the live preview components itself but we can explore as part of another story. This is just to ensure that we are writing reusable code that will reduce tedious work long term. Rest everything looks good.
arunshenoy99
requested changes
Jan 2, 2023
src/OnboardingSPA/components/RadioControl/RadioControlState/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/RadioControl/RadioControlSkeleton/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/RadioControl/RadioControlSkeleton/index.js
Outdated
Show resolved
Hide resolved
arunshenoy99
approved these changes
Jan 2, 2023
arunshenoy99
changed the base branch from
release/v1.0.0
to
release/v1.0.0-polished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.