Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press 2 458 Loader for Radio label controls #138

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/**
* Renders Skeletons for Radio Control.
*
* @param {number} data The options to be renedered
*
*/
const RadioControlSkeleton = ({ data }) => {
officiallygod marked this conversation as resolved.
Show resolved Hide resolved
const buildDummyRadioControls = () => {
const customItems = [];

for (let idx = 0; idx < data.length; idx++)
customItems.push(<div className="radio-control-skeleton-item" />);

return <div className="radio-control-skeleton">{customItems}</div>;
};

return buildDummyRadioControls();
officiallygod marked this conversation as resolved.
Show resolved Hide resolved
};

export default RadioControlSkeleton;
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*COLOR VARIABLES*/
$white-offset: rgb(224, 224, 224);
$main-color-light: var(--nfd-onboarding-white);

.radio-control {

&-main {
animation: fadeIn 300ms ease-in;
}

&-skeleton {
margin: 30px;

&-item {
height: 32px;
margin: 12px;
padding: 10px;
background: transparent;
}
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { useState, useEffect } from '@wordpress/element';
import RadioControlSkeleton from '../RadioControlSkeleton';

/**
* A State Handler to manage Radio Control
*
* @param {number} data The options to be renedered.
* @param {string} children The children to be rendered out.
* @param {number} watch The variable to be awaited for to be fetched.
*
*/
const RadioControlState = ({ data, watch, children }) => {
officiallygod marked this conversation as resolved.
Show resolved Hide resolved
const [rerender, doRerender] = useState(0);

useEffect(() => doRerender(1), [watch]);

return !watch ? (
<RadioControlSkeleton data={data} />
) : (
<>
{<div style={{ display: 'none' }}>{rerender}</div>}
{children}
</>
);
};

export default RadioControlState;
2 changes: 2 additions & 0 deletions src/OnboardingSPA/components/RadioControl/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export { default as RadioCtrlSkeleton } from './RadioControlSkeleton';
export { default as RadioCtrlStateHandler } from './RadioControlState';
officiallygod marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@ import { __, sprintf } from '@wordpress/i18n';
import { translations } from '../../../../../../utils/locales/translations';
import { institution } from '@wordpress/icons';

const getContents = ( brandName, techSupportLink, fullServiceCreativeTeamLink ) => {
const getContents = (
brandName,
techSupportLink,
fullServiceCreativeTeamLink
) => {
return {
introduction: {
heading: __( 'Tax Info', 'wp-module-onboarding' ),
subheading: sprintf(
/* translators: 1: Site 2: Brand 3: Site */
__(
'A %s that does taxes in one click. That’s pretty novel.'
),
__( 'A %s that does taxes in one click. That’s pretty novel.' ),
translations( 'site' ),
brandName,
translations( 'Site' )
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,24 @@ const StepIntroPanel = lazy( () =>
);

const LearnMore = () => {
const { brandName, techSupportLink, fullServiceCreativeTeamLink } = useSelect( ( select ) => {
return {
brandName: select( nfdOnboardingStore ).getNewfoldBrandName(),
techSupportLink: select( nfdOnboardingStore ).getTechSupportUrl(),
fullServiceCreativeTeamLink: select( nfdOnboardingStore ).getfullServiceCreativeTeamUrl(),
};
} );
const { brandName, techSupportLink, fullServiceCreativeTeamLink } =
useSelect( ( select ) => {
return {
brandName: select( nfdOnboardingStore ).getNewfoldBrandName(),
techSupportLink:
select( nfdOnboardingStore ).getTechSupportUrl(),
fullServiceCreativeTeamLink:
select(
nfdOnboardingStore
).getfullServiceCreativeTeamUrl(),
};
} );

const content = getContents( brandName, techSupportLink, fullServiceCreativeTeamLink );
const content = getContents(
brandName,
techSupportLink,
fullServiceCreativeTeamLink
);

return (
<div className="nfd-onboarding-sidebar-learn-more__ecommerce-tax-info">
Expand All @@ -61,7 +70,7 @@ const LearnMore = () => {
<ButtonWhite
text={ content.help.fullService.text }
onClick={ () =>
( window.open( content.help.fullService.link, '_blank') )
window.open( content.help.fullService.link, '_blank' )
}
/>
<SupportLink
Expand Down
69 changes: 43 additions & 26 deletions src/OnboardingSPA/pages/Steps/Ecommerce/StepTax/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { EcommerceStateHandler } from '../../../../components/StateHandlers';
import { store as nfdOnboardingStore } from '../../../../store';
import content from '../content.json';
import { useWPSettings } from '../useWPSettings';
import { RadioCtrlStateHandler } from '../../../../components/RadioControl';

function createReverseLookup(state) {
return (option) =>
Expand Down Expand Up @@ -74,6 +75,22 @@ const StepTax = () => {
navigate('/ecommerce/step/products');
};

const selectOption = (value) => {
let selectedOption = content.stepTaxOptions.find(
(option) => option.value === value
);
setCurrentOnboardingData({
storeDetails: {
...currentData.storeDetails,
tax: {
...selectedOption.data,
option: selectedOption.value,
isStoreDetailsFilled: tax?.isStoreDetailsFilled
},
},
});
}

return (
<EcommerceStateHandler>
<CommonLayout isBgPrimary isCentered>
Expand All @@ -85,33 +102,33 @@ const StepTax = () => {
subHeading={__(content.stepTaxSubHeading, 'wp-module-onboarding')}
question={__(content.question, 'wp-module-onboarding')}
/>
{settings === null && <p>Loading...</p>}
</div>
<RadioControl
className='nfd-onboarding-experience-step-tabs components-radio-control__input radio-control-tax-step'
selected={tax?.option}
options={content.stepTaxOptions.map((option) => {
return {
label: __(option.content, 'wp-module-onboarding'),
value: option.value,
};
})}
onChange={(value) => {
let selectedOption = content.stepTaxOptions.find(
(option) => option.value === value
);
setCurrentOnboardingData({
storeDetails: {
...currentData.storeDetails,
tax: {
...selectedOption.data,
option: selectedOption.value,
isStoreDetailsFilled: tax?.isStoreDetailsFilled
},
},
});
}}
/>
<RadioCtrlStateHandler
watch={ settings }
data={ content.stepTaxOptions }
>
<RadioControl
className={
'nfd-onboarding-experience-step-tabs components-radio-control__input radio-control-tax-step radio-control-main'
}
selected={ tax?.option }
options={ content.stepTaxOptions.map(
( option ) => {
return {
label: __(
option.content,
'wp-module-onboarding'
),
value: __(
option.value,
'wp-module-onboarding'
),
};
}
)}
onChange={( value ) => selectOption( value )}
/>
</RadioCtrlStateHandler>
<button
className='nfd-nav-card-button nfd-card-button'
disabled={settings === null || tax?.option === undefined}
Expand Down
2 changes: 1 addition & 1 deletion src/OnboardingSPA/pages/Steps/Ecommerce/stylesheet.scss
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ div.onboarding-product-step {

.radio-control-tax-step {
label {
padding: 10px 190px 10px 15px;
padding: 10px 100px 10px 20px;
}

@media (max-width: #{ ($break-medium - 1) }) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { translations } from '../../../../../../utils/locales/translations';
import { home } from '@wordpress/icons';

const getContents = ( techSupportLink, fullServiceCreativeTeamLink ) => {

return {
introduction: {
heading: __( 'WordPress Experience', 'wp-module-onboarding' ),
Expand All @@ -24,10 +23,7 @@ const getContents = ( techSupportLink, fullServiceCreativeTeamLink ) => {
information: {
headingWithDescriptions: [
{
heading: __(
'Why we ask',
'wp-module-onboarding'
),
heading: __( 'Why we ask', 'wp-module-onboarding' ),
description: __(
`We use this to help offer the best WordPress setup, features and suggestions for your site.`,
'wp-module-onboarding'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,18 @@ const StepIntroPanel = lazy( () =>
);

const LearnMore = () => {

const { techSupportLink, fullServiceCreativeTeamLink } = useSelect( ( select ) => {
return {
techSupportLink: select( nfdOnboardingStore ).getTechSupportUrl(),
fullServiceCreativeTeamLink: select( nfdOnboardingStore ).getfullServiceCreativeTeamUrl(),
};
} );
const { techSupportLink, fullServiceCreativeTeamLink } = useSelect(
( select ) => {
return {
techSupportLink:
select( nfdOnboardingStore ).getTechSupportUrl(),
fullServiceCreativeTeamLink:
select(
nfdOnboardingStore
).getfullServiceCreativeTeamUrl(),
};
}
);

const content = getContents( techSupportLink, fullServiceCreativeTeamLink );

Expand All @@ -61,7 +66,7 @@ const LearnMore = () => {
<ButtonWhite
text={ content.help.fullService.text }
onClick={ () =>
( window.open( content.help.fullService.link, '_blank') )
window.open( content.help.fullService.link, '_blank' )
}
/>
<SupportLink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { RadioControl } from '@wordpress/components';
import { useState, useEffect } from '@wordpress/element';
import { useDispatch, useSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import { RadioCtrlStateHandler } from '../../../../components/RadioControl';

/**
* Get Started: WordPress Experience Comfort Level.
Expand Down Expand Up @@ -80,23 +81,32 @@ const GetStartedExperience = () => {
question={ currentStep.subheading }
/>
</div>
<RadioControl
className="nfd-onboarding-experience-step-tabs components-radio-control__input"
selected={ wpComfortLevel }
options={ content.options.map( ( option ) => {
return {
label: __(
option.content,
'wp-module-onboarding'
),
value: __(
option.value,
'wp-module-onboarding'
),
};
} ) }
onChange={ ( value ) => setWpComfortLevel( value ) }
/>
<RadioCtrlStateHandler
watch={ wpComfortLevel }
data={ content.options }
>
<RadioControl
className={
'nfd-onboarding-experience-step-tabs components-radio-control__input radio-control-main'
}
selected={ wpComfortLevel }
options={ content.options.map(
( option ) => {
return {
label: __(
option.content,
'wp-module-onboarding'
),
value: __(
option.value,
'wp-module-onboarding'
),
};
}
)}
onChange={( value ) => setWpComfortLevel( value )}
/>
</RadioCtrlStateHandler>
<NavCardButton
text={ __(
content.buttonText,
Expand Down
1 change: 1 addition & 0 deletions src/OnboardingSPA/styles/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
@import "../components/ErrorState/stylesheet";
@import "../components/CheckboxTemplate/CheckboxItem/stylesheet";
@import "../components/CheckboxTemplate/CheckboxList/stylesheet";
@import "../components/RadioControl/RadioControlSkeleton/stylesheet";
@import "../components/CheckboxTemplate/CheckboxListSkeleton/stylesheet";
@import "../components/Sidebar/components/LearnMore/Skeleton/stylesheet";

Expand Down