Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press 2 470 Improve Social Media capture UI #140

Conversation

officiallygod
Copy link
Member

No description provided.

@officiallygod officiallygod added the Post Phase 2 Polish Polish PR's for work done in Phase 2 label Dec 21, 2022
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be scrolling up/down when one of the social media icons are clicked?
screen-capture.webm

src/OnboardingSPA/components/MiniPreview/index.js Outdated Show resolved Hide resolved
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and let's format these files as well, rest all looks good.

src/OnboardingSPA/components/MiniPreview/index.js Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 changed the base branch from release/v1.0.0 to release/v1.0.0-polished January 4, 2023 06:37
@arunshenoy99 arunshenoy99 merged commit 2f73e05 into release/v1.0.0-polished Jan 4, 2023
@arunshenoy99 arunshenoy99 deleted the PRESS-2-470-Improve-Social-Media-Capture-UI branch January 4, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post Phase 2 Polish Polish PR's for work done in Phase 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants