Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protobuf upgrade step from GHA #1661

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Jul 10, 2023

This PR removes protobuf upgrade step from workflow file causing integration test failures

The protobuf version should be dictated by the setup.py file

@rahul-tuli rahul-tuli self-assigned this Jul 10, 2023
@rahul-tuli rahul-tuli added the bug Something isn't working label Jul 10, 2023
@bfineran bfineran merged commit b802048 into pytorch_test_fix Jul 10, 2023
@bfineran bfineran deleted the fix-integration-tests branch July 10, 2023 18:53
dsikka added a commit that referenced this pull request Jul 10, 2023
* fix broken protobuf ranges

* Remove protobuf upgrade step from GHA (#1661)

* Remove protobuf upgrade step

* Remove protobuf upgrade step from other workflows

---------

Co-authored-by: Rahul Tuli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants