Fix broken protobuf ranges (#1660)

* fix broken protobuf ranges * Remove protobuf upgrade step from GHA (#1661) * Remove protobuf upgrade step * Remove protobuf upgrade step from other workflows --------- Co-authored-by: Rahul Tuli <[email protected]>
neuralmagic · Jul 10, 2023 · 3501ee5 · 3501ee5
1 parent c8f2429
commit 3501ee5
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 9 deletions.
diff --git a/.github/workflows/Integrations-post-merge-check.yaml b/.github/workflows/Integrations-post-merge-check.yaml
@@ -41,8 +41,6 @@ jobs:
         run: pip3 install -U pip && pip3 install setuptools sparsezoo/
       - name: "Clean sparsezoo directory"
         run: rm -r sparsezoo/
-      - name: "Upgrade protobuf version"
-        run: pip3 install --upgrade protobuf
       - name: "⚙️ Install dependencies"
         run: pip3 install .[dev,torchvision,deepsparse,onnxruntime,transformers,yolov5]
       - name: "🔬 Running integrations tests (cadence: commit}})"

diff --git a/.github/workflows/integrations-check.yaml b/.github/workflows/integrations-check.yaml
@@ -62,8 +62,6 @@ jobs:
         run: pip3 install -U pip && pip3 install setuptools sparsezoo/
       - name: "Clean sparsezoo directory"
         run: rm -r sparsezoo/
-      - name: "Upgrade protobuf version"
-        run: pip3 install --upgrade protobuf
       - name: "⚙️ Install dependencies"
         run: pip3 install .[dev,torchvision,deepsparse,onnxruntime,transformers,yolov5]
       - name: "🔬 Running integrations tests (cadence: pre-commit}})"

diff --git a/.github/workflows/test-check.yaml b/.github/workflows/test-check.yaml
@@ -73,8 +73,6 @@ jobs:
         run: pip3 install -U pip && pip3 install setuptools sparsezoo/
       - name: "Clean sparsezoo directory"
         run: rm -r sparsezoo/
-      - name: "Upgrade protobuf version"
-        run: pip3 install --upgrade protobuf
       - name: "⚙️ Install dependencies"
         run: pip3 install .[dev,onnxruntime]
       - name: "🔬 Running base tests"
@@ -99,8 +97,6 @@ jobs:
         run: pip3 install -U pip && pip3 install setuptools sparsezoo/
       - name: "Clean sparsezoo directory"
         run: rm -r sparsezoo/
-      - name: "Upgrade protobuf version"
-        run: pip3 install --upgrade protobuf
       - name: "⚙️ Install dependencies"
         run: pip3 install .[dev,deepsparse,onnxruntime]
       - name: "🔬 Running deepsparse tests"

diff --git a/setup.py b/setup.py
@@ -52,7 +52,7 @@
     "tqdm>=4.0.0",
     "toposort>=1.0",
     "GPUtil>=1.4.0",
-    "protobuf>=3.12.2",
+    "protobuf>=3.12.2,<=3.20.3",
     "click>=7.1.2,!=8.0.0",  # latest version < 8.0 + blocked version with reported bug
 ]
 _nm_deps = [f"{'sparsezoo' if is_release else 'sparsezoo-nightly'}~={version_nm_deps}"]