Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken protobuf ranges #1660

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Fix broken protobuf ranges #1660

merged 3 commits into from
Jul 10, 2023

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Jul 10, 2023

  • Fix protobuf ranges to account for updates in other packages and get our pytorch tests working

@dsikka dsikka requested review from bfineran and rahul-tuli July 10, 2023 18:14
rahul-tuli
rahul-tuli previously approved these changes Jul 10, 2023
bfineran
bfineran previously approved these changes Jul 10, 2023
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that @mgoin recently uncapped the range to enable onnx 1.14. It looks like 3.20.2 is in range so we should be good to both fix our issue for now while keeping onnx 1.14 enabled

* Remove protobuf upgrade step

* Remove protobuf upgrade step from other workflows
@bfineran bfineran dismissed stale reviews from rahul-tuli and themself via b802048 July 10, 2023 18:53
@dsikka dsikka merged commit 3501ee5 into main Jul 10, 2023
@dsikka dsikka deleted the pytorch_test_fix branch July 10, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants