15764 change vc_position from PositiveSmallInteger to PositiveInteger #15779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Apr 19, 2024
Just wanted to add this for completeness. We absolutely use position 0, as the ASR9K chassis in my example is referred to as Rack 0 within the equipment and uses 0 in its interface naming. An example for Junos was discussed in #7564 previously as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15764
Change vc_position from PositiveSmallInteger to PositiveInteger - form field and serializer are already IntegerField so no changes needed there.
Note: We had talked about min-value of 1, but there was no min-value currently on the field and the serializer has min-value of 0 so it's possible someone already has 0 in the DB so didn't want to change.