Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum value for VC position on the Device model #15764

Closed
sleepinggenius2 opened this issue Apr 18, 2024 · 0 comments
Closed

Increase maximum value for VC position on the Device model #15764

sleepinggenius2 opened this issue Apr 18, 2024 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@sleepinggenius2
Copy link
Contributor

NetBox version

v3.7.5

Feature type

Change to existing functionality

Proposed functionality

The VC position on the Device model is currently limited to 255. My proposal would be to increase this to at least 65534, but it may need to be higher in other environments.

Use case

I recently ran into an issue within our network due to the 255 limit on VC position. Cisco ASR9K devices allow specifying a satellite ID up to 65534, which seems like the exact use case for the VC model, a master chassis and a subtended one, but that means we want to set position 0 for the main router and use the satellite's ID for it's position in the VC, as that is used in provisioning and in its port naming. I was able to change the maximum value in the model within our NetBox instance and it didn't seem to cause any issues for a value < 32767, but 65534 would overflow a small int, as the type is currently configured, due to its signed nature.

Example from the router configuration:

#nv satellite ?
  <100-65534>  Satellite ID

Database changes

The vc_position field on the Device model would need to be changed from a smallint to an integer type to support a value of 65534.

External dependencies

None

@sleepinggenius2 sleepinggenius2 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Apr 18, 2024
@arthanson arthanson added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 18, 2024
@arthanson arthanson removed their assignment Apr 18, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Apr 19, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants