virtual-chassis position zero

[PieterL75]

NetBox version

v3.0.7

Python version

3.7

Steps to Reproduce

1. Create 2 devices
2. Create a new virtual chassis
3. Set the Initial position to zero
4. add the 2 devices
5. Create the Virtual Chassis

Next one, also related

1. Edit the virtual chassis
2. Set the posistions to 0 an 1
3. Save the VC
4. check the overview of devices in the VC

Expected Behavior

A new VC is created with 2 members. with position 0 en 1.
The GUI shows the 0 and 1 position in a gray box

Observed Behavior

The members are created with position 1 and 2.

After correcting: The position 0 is not displayed

[PieterL75]

First issue seems to be related to this :

netbox/netbox/dcim/forms/object_create.py

Line 125 in 16f5e23

initial_position = self.cleaned_data.get('initial_position') or 1

This will cause 'initial_position' to become '1' if the get('initial_position') equals to {int}0
a=0
b=a or 1
b becomes 1
It can be fixed with
initial_position = self.cleaned_data.get('initial_position') if initial_position != None else 1

The second can be solved with this :

netbox/netbox/utilities/templatetags/helpers.py

Line 378 in a1f271d

'value': value,

Change that to
'value': str(value),

[DanSheps]

What NOS allows a position of "0" for a virtual chassis?

[PieterL75]

Junos has 0 for the first chassis id.. Ex https://www.juniper.net/documentation/us/en/software/junos/virtual-chassis-mx/topics/ref/command/show-virtual-chassis-status-mx-series.html Pieter Op ma 18 okt. 2021 22:43 schreef Daniel Sheppard ***@***.***>:

…

What NOS allows a position of "0" for a virtual chassis? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7564 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR3OADAIFQBHWIZ6BYYHPYLUHSBIPANCNFSM5GGQOYKA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[PieterL75]

You can assign it to me..

[jeremystretch]

Argh. Fixed in 3cb8c5d but I typoed the commit message.