Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit VLANs displayed on interface tables #17655

Closed
thordreier opened this issue Oct 2, 2024 · 3 comments · Fixed by #17662
Closed

Limit VLANs displayed on interface tables #17655

thordreier opened this issue Oct 2, 2024 · 3 comments · Fixed by #17662
Assignees
@thordreier
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@thordreier
Copy link
Contributor

NetBox version

v4.1.2

Feature type

Change to existing functionality

Proposed functionality

Limit number of tagged VLANs shown on interface/vminterface table to 3 VLANs. If interface is connected to more than 3 VLANs, then show a link to full list. Just like with IP addresses, that was implemented in #14645

Use case

Make overview of interfaces more readable, if a device has some interfaces that's connected to many VLANs.

Database changes

No response

External dependencies

No response
@thordreier thordreier added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Oct 2, 2024
@thordreier
Copy link
Contributor Author

Suggested solution can be found in this commit: thordreier@9495964

@DanSheps DanSheps added status: accepted This issue has been accepted for implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Oct 2, 2024
@DanSheps
Copy link
Member

DanSheps commented Oct 2, 2024

@thordreier Since you have a commit for this, I am just going to make the leap that you would like to submit a PR.

@thordreier thordreier mentioned this issue Oct 2, 2024
Merged
jeremystretch added a commit that referenced this issue Oct 7, 2024
@jeremystretch
Changelog for #17079, #17566, #17648, #17655
ebd6c59
bctiemann pushed a commit that referenced this issue Oct 11, 2024
@jeremystretch @bctiemann
Changelog for #17079, #17566, #17648, #17655
4ebc0f5
jeremystretch added a commit to alehaa/netbox that referenced this issue Oct 11, 2024
@jeremystretch
Changelog for netbox-community#17079, netbox-community#17566, netbox-…
03ec57f 
…community#17648, netbox-community#17655
@jeremystretch jeremystretch mentioned this issue Oct 15, 2024
Merged
@Azmodeszer Azmodeszer mentioned this issue Oct 16, 2024
Open
@salfers
Copy link

salfers commented Oct 16, 2024

Will there be an option to change the display limit or disable it?
I understand the readability concern but rather prefer to have all information on the interfaces page so I can ctrl+f for VLANs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thordreier thordreier

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

limits vlans on interface tables thordreier/netbox
3 participants
@DanSheps @thordreier @salfers