Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to limit IP Addresses displayed in interface tables #14645

Closed
JohannesKreuzer opened this issue Dec 31, 2023 · 5 comments · Fixed by #14868
Closed

Add option to limit IP Addresses displayed in interface tables #14645

JohannesKreuzer opened this issue Dec 31, 2023 · 5 comments · Fixed by #14868
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@JohannesKreuzer
Copy link

NetBox version

v3.6.9

Feature type

Change to existing functionality

Proposed functionality

Allow to limit the list of IP Addresses to e.g. 10, so interfaces with many assigned IPs won't clog the table.

Use case

When having e.g. NAT interfaces with 256 assigned IPs on a central firewall on a virtual interface this will clog the table, e.g. making it hard to find the next interface and also the name for the current interface. So an option to limit the viewed addresses would be handy.

Possible look, when limited to 10 addresses:
image

Database changes

N/A

External dependencies

No response

@JohannesKreuzer JohannesKreuzer added the type: feature Introduction of new functionality to the application label Dec 31, 2023
@jeremystretch
Copy link
Member

When having e.g. NAT interfaces with 256 assigned IPs on a central firewall on a virtual interface this will clog the table

This occurs because you're incorrectly modeling IP address assignments. IP addresses belonging to a NAT pool should not be assigned to an interface.

@JohannesKreuzer
Copy link
Author

So what is you suggestion on how to model the link of the NAT pool to the device performing the NAT?

@jeffgdotorg jeffgdotorg added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 3, 2024
@jeffgdotorg
Copy link
Contributor

Hi there, product manager weighing in here.

I've labeled this FR with status: needs owner because we think there's value in the behavior you describe, despite any misgivings about your particular use case.

For what it's worth, I suggest looking into using IP ranges to model your NAT pools. You can find details in the IPAM docs.

@abhi1693
Copy link
Member

abhi1693 commented Jan 8, 2024

Would it make sense to just show the count of IP addresses? If so, I can take onwership of this issue.

@JohannesKreuzer
Copy link
Author

I personally would display IPs if there are only 1 or 2 assigned and otherwise say e.g. 30 IP addresses assigned.

@abhi1693 abhi1693 self-assigned this Jan 18, 2024
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 18, 2024
jeremystretch added a commit that referenced this issue Jan 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants