Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The VirtualMachineType in GraphQL is missing the contacts property #15347

Closed
klstilling opened this issue Mar 5, 2024 · 4 comments · Fixed by #15418
Closed

The VirtualMachineType in GraphQL is missing the contacts property #15347

klstilling opened this issue Mar 5, 2024 · 4 comments · Fixed by #15418
Assignees
@jeremystretch
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation topic: GraphQL type: bug A confirmed report of unexpected behavior in the application

Comments

@klstilling
Copy link

NetBox version

v3.7.3

Feature type

Data model extension

Proposed functionality

I propose that the ContactMixin class is added to the VirtualMachineType class in the GraphQL files. I was wondering where I could find it, as I could find the property in the DeviceType class. I have a pull request ready which I'd be happy to submit for review.

Use case

It allows users to get information about contacts associated with virtual machine objects

Database changes

None

External dependencies

None
@klstilling klstilling added the type: feature Introduction of new functionality to the application label Mar 5, 2024
klstilling pushed a commit to klstilling/netbox that referenced this issue Mar 5, 2024
feat(graphql): add ContactMixin property to VirtualMachineType
e76b018 
This exposes the `contacts` property to `virtual_machines` objects in
GraphQL.

Closes netbox-community#15347
@jeremystretch
Copy link
Member

Sounds like a bug.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows topic: GraphQL and removed type: feature Introduction of new functionality to the application labels Mar 8, 2024
@klstilling
Copy link
Author

@jeremystretch I'd be happy to help. By applying the changes in klstilling@e76b018 the property becomes available in the GraphQL API. If there's anything I can do, just poke me.

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Mar 10, 2024
@arthanson arthanson added the status: blocked Another issue or external requirement is preventing implementation label Mar 11, 2024
@arthanson
Copy link
Collaborator

This is blocked by #9856 as it is completely rewritten what is returned.

@arthanson arthanson removed the status: accepted This issue has been accepted for implementation label Mar 11, 2024
jeremystretch added a commit that referenced this issue Mar 13, 2024
@jeremystretch
Fixes #15347: Fix querying virtual machine contacts via GraphQL
afc4966
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Mar 13, 2024
@jeremystretch
Copy link
Member

Although we are completely gutting the GraphQL code with the move to Strawberry in v4.0, this seems like a simple fix we can squeeze into the current code base without much hassle.

@jeremystretch jeremystretch mentioned this issue Mar 13, 2024
Merged
jeremystretch added a commit that referenced this issue Mar 13, 2024
@jeremystretch
Fixes #15347: Fix querying virtual machine contacts via GraphQL
7350950
jeremystretch added a commit that referenced this issue Mar 13, 2024
@jeremystretch
Changelog for #13722, #14206, #14366, #14832, #15322, #15347, #15356
df7905d
@jeremystretch jeremystretch mentioned this issue Mar 13, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation topic: GraphQL type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15347: Fix querying virtual machine contacts via GraphQL netbox-community/netbox
4 participants
@arthanson @abhi1693 @klstilling @jeremystretch