Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add SFP+ types #14206

Closed
ljem86 opened this issue Nov 7, 2023 · 3 comments · Fixed by #15391
Closed

Request to add SFP+ types #14206

ljem86 opened this issue Nov 7, 2023 · 3 comments · Fixed by #15391
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@ljem86
Copy link

ljem86 commented Nov 7, 2023

NetBox version

v3.4.5

Feature type

Change to existing functionality

Proposed functionality

Netbox currently supports:

# Fibrechannel
TYPE_1GFC_SFP = '1gfc-sfp'
TYPE_2GFC_SFP = '2gfc-sfp'
TYPE_4GFC_SFP = '4gfc-sfp'
TYPE_8GFC_SFP_PLUS = '8gfc-sfpp'
TYPE_16GFC_SFP_PLUS = '16gfc-sfpp'
TYPE_32GFC_SFP28 = '32gfc-sfp28'
TYPE_64GFC_QSFP_PLUS = '64gfc-qsfpp'
TYPE_128GFC_QSFP28 = '128gfc-qsfp28'

What we need to add:

TYPE_32GFC_SFP_PLUS = '32gfc-sfpp’          => [Brocade 32Gb/s SWL SFP+ Product Brief](https://urldefense.com/v3/__https:/docs.broadcom.com/docs/GA-DS-2048__;!!BhdT!ls37dMy4pnF-6hdYjEYU8fb0n6iAjFY6b79usqjQOZ2rQE8wrRVNwh-m5e35xVboDcJ1jLAri-dA37NF2R1jRDFY$)
TYPE_64GFC_SFP_PLUS = '64gfc-sfpp’          => [Brocade 32Gb/s SWL SFP+ Product Brief](https://urldefense.com/v3/__https:/docs.broadcom.com/docs/GA-DS-2048__;!!BhdT!ls37dMy4pnF-6hdYjEYU8fb0n6iAjFY6b79usqjQOZ2rQE8wrRVNwh-m5e35xVboDcJ1jLAri-dA37NF2R1jRDFY$)
TYPE_64GFC_SFP_DD = '64gfc-sfpdd'            => [Brocade 64G SWL SFP-DD Product Brief](https://urldefense.com/v3/__https:/docs.broadcom.com/docs/SFP-DD-64G-SWL-PB__;!!BhdT!ls37dMy4pnF-6hdYjEYU8fb0n6iAjFY6b79usqjQOZ2rQE8wrRVNwh-m5e35xVboDcJ1jLAri-dA37NF2eSQwXt0$)

Use case

We need to have above types added to Netbox as we are using them to build out DC. It will be usefull for the other users building the environment by Brocade vendor devices.

Database changes

No response

External dependencies

No response

@ljem86 ljem86 added the type: feature Introduction of new functionality to the application label Nov 7, 2023
@apellini
Copy link
Contributor

apellini commented Dec 4, 2023

if @jeremystretch approves I could do that

@DanSheps DanSheps added the status: accepted This issue has been accepted for implementation label Jan 18, 2024
@DanSheps
Copy link
Member

@apellini I have assigned this to you.

@netbox-community netbox-community deleted a comment from eltoli01 Jan 18, 2024
@netbox-community netbox-community deleted a comment from crijnsj Jan 18, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Mar 9, 2024
@markkuleinio
Copy link
Contributor

@jeremystretch I can do this

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Mar 10, 2024
markkuleinio added a commit to markkuleinio/netbox that referenced this issue Mar 10, 2024
jeremystretch pushed a commit that referenced this issue Mar 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants