Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Types "All Data (YAML)" export does not include Description #15322

Closed
szeestraten opened this issue Mar 1, 2024 · 2 comments · Fixed by #15419
Closed

Device Types "All Data (YAML)" export does not include Description #15322

szeestraten opened this issue Mar 1, 2024 · 2 comments · Fixed by #15419
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@szeestraten
Copy link

Deployment Type

Self-hosted

NetBox Version

v3.7.3

Python Version

3.8

Steps to Reproduce

  1. Create Device Type with a description
  2. Export Device Types with "All Data (YAML)" export
  3. Examine export which does not include the Description field of the device type the set description that was set

Reproducible on demo.netbox.dev

Expected Behavior

Expect the Description field to be present in export.

Observed Behavior

No Description field is present in export.
@szeestraten szeestraten added the type: bug A confirmed report of unexpected behavior in the application label Mar 1, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Mar 1, 2024
@jeremystretch
Copy link
Member

Looks like the description field is missing from the to_yaml() method on the DeviceType model. It's probably worth a quick audit for missing fields in the method on other models too.

@jeremystretch
Copy link
Member

The description field is missing from ModuleType as well.

@jeremystretch jeremystretch self-assigned this Mar 13, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Mar 13, 2024
jeremystretch added a commit that referenced this issue Mar 13, 2024
@jeremystretch
Fixes #15322: Add description field to YAML export for device & modul…
a6ec7fe 
…e types
@jeremystretch jeremystretch mentioned this issue Mar 13, 2024
Merged
jeremystretch added a commit that referenced this issue Mar 13, 2024
@jeremystretch
Fixes #15322: Add description field to YAML export for device & modul…
8bdbb49 
…e types
jeremystretch added a commit that referenced this issue Mar 13, 2024
@jeremystretch
Changelog for #13722, #14206, #14366, #14832, #15322, #15347, #15356
df7905d
@jeremystretch jeremystretch mentioned this issue Mar 13, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15322: Add description field to YAML export for device & module types netbox-community/netbox
2 participants
@szeestraten @jeremystretch