-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare version 1.0.0 #394
Conversation
This commit adds links to the _New Issue_ section of Github. The intention is to provide more hints where to get help and further reduce the amount of Github issues that can not be acted upon.
Links for issues
We now serve Netbox with an nginx-unit instance instead of Gunicorn. This allows us to get rid of the extra Nginx container because Unit is also serving the static files. The static files are now collected at container buildtime instead of every startup.
Use Nginx Unit to serve the application
fix issue where user has no virtual machines defined, but startup script still tries to iterate over empty file.
Expand Initialization Support
Ah, of course.. I would agree. :) Co-authored-by: Christian Mäder <[email protected]>
Configure Renovate
Bugfix - Allow primary device IP without virtual machine initialization
I would like to also have #391 in here as well, so I have not approved yet. But this will become another kick-ass release 💪 :) |
Alpine is releases a new version once a year. Therefore our workflow runs don't need to be marked as failed when run on alpine:edge
…itTests Skip Startup Scripts in Unit Tests
Prevent "alpine:edge" from failling the workflow
Update of ruamel.yaml
I was just thinking whether this should become a |
I've took the liberty to update your description with a draft for the release notes. |
This is a big change and the new image won't be compatible with old compose and configuration files. I like the idea of a 1.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ready for this? 😇
I think so. |
Just to note that it's not clear from the documentation that you can't use this docker-compose configuration with older versions of netbox (I was trying to create a local environment matching our production env (v2.9.x) and this change caught me out) |
I disagree. Our release notes clearly state which release of Netbox Docker works with which release of Netbox, e.g. today's version 1.0.2:
Also, since a few hours ago, this exists with an improved wording: https://github.com/netbox-community/netbox-docker/wiki/Version |
Ok, let me rephrase. It's possible (and I decided to comment here because I spent some time trying to work it out myself) to get to the front page of the project/ read the docker hub page and see the note about Thanks for your work on this project :-) |
Related Issue:-
New Behavior
Contrast to Current Behavior
Discussion: Benefits and Drawbacks
Changes to the Wiki
Proposed Release Note Entry
Double Check
develop
branch.