-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Initialization Support #384
Conversation
Need to think about how to handle option_assoc for 1 to many associations added for VRFs and Route Targets (for import and export targets):
The same problem exists for tagged_vlans being associated to interfaces. We likely need to recognize the key as a list and loop through each item for querying the association. |
PR has been tested with all sample data. Non-blocking nice to have items I leave up to @cimnine & @tobiasge to opine on are:
I will adjust based on feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have to test it, but from what I've seen this looks solid. Thank you!
There seems to be a problem with the power feed startup script or initializer yaml. To see it locally, run: ./build.sh master
./test.sh latest See https://gist.github.com/cimnine/1201c3c93aa1ff1ded5d99f931a0b505 |
I am assuming the 2 failed checks are unrelated to my PR |
Yes, they're unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
Thanks for your assistance! |
Related Issue: #383
New Behavior
Add additional Startup Scripts and example Initialization YAMLs
Contrast to Current Behavior
New Feature expanding Startup Scripts Function
Discussion: Benefits and Drawbacks
See linked Issue / Feature Request
Changes to the Wiki
Current Wiki entry pretty much covers these new additions
Proposed Release Note Entry
Added new startup scripts for [insert items once we finalize]
Double Check
develop
branch.