Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Initializers Support #383

Closed
ryanmerolle opened this issue Dec 29, 2020 · 3 comments · Fixed by #384
Closed

Expand Initializers Support #383

ryanmerolle opened this issue Dec 29, 2020 · 3 comments · Fixed by #384
Labels
enhancement The issue describes an enhancement that we would like to implement in the future. pr There is a PR targeting this issue.
Milestone

Comments

@ryanmerolle
Copy link
Contributor

Desired Behavior

Add support for startup scripts to load all data Netbox supports.

Contrast to Current Behavior

I think only the circuits models are not supported. IE CircuitType, Circuit, CircuitTermination, Provider.

Changes Required

Create startup scripts and initializer yamls for the missing models.

Discussion: Benefits and Drawbacks

Benefits include a more complete set of initializers that NetBox supports. This allows developers, testers, and prod deployments to more fully leverage initializers for getting a deployment up and running.

Drawbacks really are the same as any startup script included in this project, IE that the project needs to update to match the data model and that its all not necessarily within the core function of what the docker project is focused on.

@ryanmerolle
Copy link
Contributor Author

ryanmerolle commented Dec 30, 2020

I have a PR coming but, the most obvious missing initializers & startup scripts are
Easy or ROI(I will check off what I have completed):

  • Tags
  • Secret Roles
  • Cluster Groups
  • Providers
  • CircuitTypes
  • Circuits
  • PowerPanels
  • PowerFeeds
  • Route Target
  • Service

May not be worth the ROI(Feel free to comment if these should be included):

  • Secrets (not something I think would get used since it defeats the purpose to save in clear text, but may be useful for loading test data)
  • Rack Reservations (Easy to add, but the model requires a user, would need to pass the admin user environment var)
  • CableTermination
  • CircuitTermination
  • Other (not CableTermination) Device Component models (should mostly be handled by device types being predefined)
  • Cables Model
  • Device Component Templates models

Assuming @cimnine and @tobiasge are ok with this all, I would look reorder the existing startup_scripts to execute in order based on the new startup_scripts I would create.

@ryanmerolle ryanmerolle linked a pull request Dec 31, 2020 that will close this issue
3 tasks
@cimnine cimnine added enhancement The issue describes an enhancement that we would like to implement in the future. pr There is a PR targeting this issue. labels Jan 7, 2021
@cimnine
Copy link
Collaborator

cimnine commented Jan 15, 2021

Secrets are about to be deprecated anyway afaik. I'd leave the other items to whoever needs them first ;)

@cimnine cimnine added this to the 0.28.0 milestone Jan 26, 2021
@cimnine
Copy link
Collaborator

cimnine commented Jan 26, 2021

Since we've merged your PR and will release your changed in the next release, I'm closing this issue. Once more, thank you for your effort.

@cimnine cimnine closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue describes an enhancement that we would like to implement in the future. pr There is a PR targeting this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants