Bugfix - Allow primary device IP without virtual machine initialization #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue where user has no virtual machines defined, but startup script still tries to iterate over empty file.
cimnine
requested changes
Jan 19, 2021
cimnine
added
awaiting answer
Ah, of course.. I would agree. :) Co-authored-by: Christian Mäder <[email protected]>
cimnine
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
Fix behavior of start up scripts, specifically 270_primary_ip where a lack of virtual machine may cause the initialization engine to crash.
...
Contrast to Current Behavior
...
Discussion: Benefits and Drawbacks
...
Changes to the Wiki
...
Proposed Release Note Entry
Fixed primary ip initialization script to allow null and/or simultaneous virtual machine initialization.
Double Check
developbranch.