profiles: add dbus filters #3326

rusty-snake · 2020-04-07T11:35:07Z

Opening as PR so we can disscuss about them. The most are just extracted from flathub, see #3265 (comment).

EDIT: everyone fell free to push more profiles here.

rusty-snake · 2020-04-07T11:43:40Z

BTW: firejail --noprofile --dbus-user=filter --audit | grep D-Bus MAYBE: D-Bus socket /run/firejail/mnt/dbus/user is available.

kris7t

First of all, thanks for creating the DBus profiles!

In the previous weeks, I was running the DBus filter with much tighter rules. As I use sway, not Gnome, desktop integration wasn't a problem, so I may be overly vigilant. Nevertheless, below I made some comments regarding the filter rules from flathub.

kris7t · 2020-04-07T11:39:04Z

etc/celluloid.profile

+dbus-user.talk org.gtk.vfs.*
+dbus-user.talk org.gtk.vfs


Is allowing Gvfs access safe? Could for example a malicious application access any Gvfs mount (and potentially e.g., spread ransomware to an unsecured samba mount, using the credentials already provided to Gvfs by the user)?

Also, I don't think you need org.gtk.vfs here, org.gtk.vfs.* covers it as well.

Resolved other org.gtk.vfs commend in order to have one thread.

Your right, the most programs don't need it.

TODO: can it be used to bypass disable-mnt/blacklist/whitelist.

etc/rhythmbox.profile

etc/feedreader.profile

kris7t · 2020-04-07T11:43:18Z

etc/templates/profile.template

+#  - In order to make dconf work (if it is used by the app) you need to allow
+#    'ca.desrt.dconf' even if it is not allowed by flatpak.
+#dbus-user filter
+#dbus-user.own com.github.netblue30.firejail


Allowing any firejailed application to own the name com.github.netblue30.firejail (and potentially impersonate firejail, if we ever add any custom DBus interfaces) sounds a bit risky.

Thats just an example, it would not pass any review. However we can change it to com.example.appname.

kris7t · 2020-04-07T11:48:33Z

etc/templates/profile.template

+#    'ca.desrt.dconf' even if it is not allowed by flatpak.
+#dbus-user filter
+#dbus-user.own com.github.netblue30.firejail
+#dbus-user.talk ca.desrt.dconf


I am not sure whether unrestricted DConf access is always a good idea. A malicious application could, for example, change stuff under org.gnome.system.proxy to MITM traffic.

Luckily, users could just ignore dbus-user.talk ca.desrt.dconf in globals.local, and selectively enable it for applications that absolutely need it.

I wonder what's the flatpak solution for this vulnerability.

I wonder what's the flatpak solution for this vulnerability.

https://docs.flatpak.org/en/latest/sandbox-permissions.html#dconf-access, a lot of flatpaks still use direct access. gnome-builder suggests it.

A malicious application could, for example, change stuff under org.gnome.system.proxy to MITM traffic.

Or even worser: /org/gnome/terminal/legacy/profiles:/<UUID>/custom-command

I only added it there as an example since it is common used.

A sandboxed dconf similar to flatpak's would be a logical next step after DBus

kris7t · 2020-04-07T11:53:10Z

etc/feedreader.profile

+dbus-user.own org.gnome.FeedReader.ArticleView
+dbus-user.talk org.freedesktop.Notifications
+dbus-user.talk org.gtk.vfs.*
+dbus-user.talk org.freedesktop.secrets


What is the access policy of the secret service? I think at least Gnome keyring only asks for the user password once (at most, never if PAM unlocks it), and provides secrets to application without any confirmation required. Although arguably, that's a vulnerability in the secret service implementation (I'm pretty sure keepassxc can be set to ask for confirmation before releasing credentials), not in the sandbox.

etc/ghostwriter.profile

kris7t · 2020-04-07T12:04:26Z

BTW: firejail --noprofile --dbus-user=filter --audit | grep D-Bus MAYBE: D-Bus socket /run/firejail/mnt/dbus/user is available.

Well, that socket is the proxy socket, so it should be present. But yeah, I should fix the audit so it does not emit a warning, it makes no sense to warn for a properly running filter.

kris7t · 2020-04-07T12:17:19Z

etc/firefox.profile

@@ -28,5 +28,11 @@ include whitelist-usr-share-common.inc
 # private-etc must first be enabled in firefox-common.profile
 #private-etc firefox

+dbus-user filter
+dbus-user.own org.mozilla.firefox.*


Starting with Firefox 75, there should probably also be a dbus-user.own org.mpris.MediaPlayer2.firefox.* for hardware media key support.

I wanted to start minimal, there a lot more path for firefox + extensions. The policy used by the inoffical firefox-flatpak:

dbus-user filter dbus-user.own org.mozilla.Firefox dbus-user.own org.mozilla.firefox.* dbus-user.talk org.freedesktop.FileManager1 dbus-user.talk org.freedesktop.Notifications dbus-user.talk org.freedesktop.ScreenSaver dbus-user.talk org.gnome.SessionManager dbus-system filter dbus-system.talk org.freedesktop.NetworkManager

Whoah, org.freedesktop.NetworkManager sounds quite evil in this context (MITM via adding a VPN, or leaking IP and MAC addresses of interfaces otherwise isolated with --net=).

Fred-Barclay · 2020-04-07T14:34:34Z

@rusty-snake I was going to replace all nodbus in profiles with

dbus-system none
dbus-user none

as a general starting point

Ok to push here or should I open a new PR? It's probably lots of files so didn't want to clutter up this PR.

rusty-snake · 2020-04-07T15:10:54Z

@Fred-Barclay if you push upstream, I can rebase.

Nitpick: I used dbus-user before dbus-system.

Fred-Barclay · 2020-04-07T15:40:35Z

@rusty-snake I'm usually bad at alphabetising... in this case though for consistency's sake I'd guess dbus-system before dbus-user. What do you think?

rusty-snake · 2020-04-07T15:51:46Z

The must profiles will disable dbus or look like the example below. For my eyes it was nicer to have a dbus-system none at the bottom instead of the top.

dbus-user filter
dbus-user.own com.foo.bar
dbus-user.talk ca.desrt.dconf
dbus-user.talk org.freedesktop.smile
dbus-system none

The addresses (grouped by own and talk) should be alphabetical sure.

See - 07fac58 for new dbus filters - #3326 (comment) Except for ocenaudio, access/restrictions on dbus options should be unchanged Ocenaudio profile: dbus filters were sandboxed (initially `nodbus` was enabled) since comments indicated blocking dbus meant preferences were broken

Fred-Barclay · 2020-04-07T21:16:46Z

@rusty-snake done, see 3848b98

There are a few small changes left, like how to handle ?HAS_NODBUS, but that should affect >5 files.

glitsj16 · 2020-04-07T23:04:00Z

etc/firefox.profile

+dbus-user.own org.mozilla.firefox.*
+dbus-user.talk org.freedesktop.Notifications
+dbus-system none
+ignore nodbus


I get why we need to have ignore nodbus here. Does that mean we can remove it from firefox-common-addons.inc?

Now needs to be ignore dbus-user none.

firefox-common.profile is used by firefox, thunderbird, waterfox, ... and disables D-Bus access. Of course we can't add the own rule to firefox-common. Because some program throw errors messages if D-Bus isn't available, but hardfail on D-Bus error due to work policy, I added this for now only to firefox.

glitsj16 · 2020-04-08T00:40:02Z

Suppose a profile has dbus-user.talk org.freedesktop.Notifications and a user wants to override that, and only that. Is ignore still the correct/preferred way to do this with regards to the DBus filters? If so, I'll add an example to man firejail-profile to avoid potential confusion.

…e.txt See discussion in #3326.

rusty-snake · 2020-04-11T17:04:32Z

I created a short list about some of the D-Bus addresses.

Legend:
# |0| => harmless
# |!| => Danger sandbox escape possible
# |!!| => Very dangerous
# |$| => sensitive

# |0| MediaKeys
org.gnome.SettingsDaemon.MediaKeys
# |!| Dconf
ca.desrt.dconf
# |0| NightMode/Screen temperaur
org.gnome.SettingsDaemon.Color
# |!!| Native notifications
org.freedesktop.Notifications
# |$| Keyring
org.freedesktop.secrets
# |$|
org.gnome.OnlineAccounts
# |0|
org.mpris.MediaPlayer2.APP
# |!!| Filesystem access (blacklist/whitelist esacape)
org.freedesktop.FileManager1
# |$| Unlock screen
org.freedesktop.ScreenSaver
# |$| reboot(?)
org.gnome.SessionManager
# |!|
org.freedesktop.NetworkManager
# |$|
org.gnome.evolution.dataserver.*
# |$|
org.freedesktop.GeoClue2
# |!|
org.gnome.Shell
# |!!|
org.gnome.Shell.*
# |!|
org.freedesktop.login1
# |!|
org.gtk.vfs.*


Things that `org.freedesktop.Notifications` can do:

# Screenshots

firejail --noprofile --dbus-user=filter --dbus-user.talk=org.freedesktop.Notifications dbus-send --session --print-reply --dest=org.freedesktop.Notifications /org/gnome/Shell/Screenshot org.gnome.Shell.Screenshot.Screenshot boolean:false boolean:false string:screenshot.png

# Unlock your screen

firejail --noprofile --dbus-user=filter --dbus-user.talk=org.freedesktop.Notifications dbus-send --session --print-reply --dest=org.freedesktop.Notifications /org/gnome/ScreenSaver org.gnome.ScreenSaver.SetActive boolean:false

# Install gnome-shell-extensions

# /org/gnome/Shell org.gnome.Shell **Eval** any code (gjs)

# /org/gnome/Mutter/ScreenCast org.gnome.Mutter.ScreenCast

Record your screen

# /org/gnome/keyring/Prompter org.gnome.keyring.internal.Prompter

IDK what it can, but keyring sounds not good.

# /org/gnome/SessionManager/EndSessionDialog org.gnome.SessionManager.EndSessionDialog

Logout; Poweroff?; Reboot?

# /org/gnome/Mutter/RemoteDesktop org.gnome.Mutter.RemoteDesktop

forward desktop

# /org/gnome/Mutter/DisplayConfig

turnoff the monitor

# force you to hard-poweroff

Fred-Barclay · 2020-04-11T17:06:30Z

@rusty-snake Awesome, care to toss it in the wiki?

rusty-snake · 2020-04-11T17:12:05Z

👍 Definitely something for the wiki. with more comments/descriptions and better formating.

What policy should be apply for org.freedesktop.Notifications?

glitsj16 · 2020-04-11T17:29:07Z

What policy should be apply for org.freedesktop.Notifications?

That's one of the reasons I wanted to add an example to the firejail-profile man page. I admit not spending a whole lot of time on it and decided to add an example on how to override a given setting. But for this I would have liked a dbus-system.talk org.freedesktop.Notifications none option (or something similar). Probably not easily - if at all - implementable, but I for one will be scanning future profiles that allow it and do whatever I can to disable. Just a personal opinion...

rusty-snake · 2020-04-11T17:35:24Z

flatpak like: dbus-user.no-talk

I would say making it opt-in for whitelisting profiles.

kris7t · 2020-04-11T17:45:49Z

something like dbus-user.no-talk is potentially tricky (originally, I considered it, but decided not to implement for now) due to the presence of .* patterns in talk rules. Basically, what should happen if we have (fictitious example, obvious not a good idea to apply these exact rules):

dbus-user.talk org.freedesktop.*
dbus-user.no-talk org.freedesktop.Notifications

The challenge here is that, as far as I could find, there is no way to pass negative rules to xdg-dbus-proxy. We could resort to an approach similar to filesystem whitelisting, i.e., allow all names below org.freedesktop current present on the bus except Notifications, but that is complicated (we have to connect to the bus and list all names) and wrong (new names may appear all the time).

Alternatively, we could just throw an error if a no-talk rule is superseded by a talk rule (i.e., a no-talk with no corresponding talk rule or a talk rule which would whitelist that exact pattern of bus name(s) is ok, but anything more general than that is an error). That's pretty much what an ignore command does, tho.

I should really look into how Flatpak handles this.

On the other hand, xdg-dbus-proxy can disable dbus interfaces and methods in a quite fine-grained manner, so the Notifications issue (with the rest of Gnome Shell being practically exposed) can be handled more easily.

rusty-snake · 2020-04-11T17:55:24Z

I would say dbus-user.no-talk can act like (no)blacklist, path/address of the no command must match the path/address of the blacklist/talk command.

glitsj16 · 2020-04-11T17:58:17Z

@kris7t Very informative ^. I might have missed it, but have there been suggestions on how to deal with org.freedesktop.portal.* (see here) yet?

rusty-snake · 2020-04-12T17:56:48Z

https://github.com/netblue30/firejail/wiki/Restrict-D-Bus -- disscussion

kris7t · 2020-04-13T11:12:11Z

@glitsj16 Unfortunately, I don't know much about xdg-portals. I think Gnome has some kind of settings dialog for at least flatpak app permissions (filesystem access, webcam, microphone, etc.). I don't know whether that's just black/whitelisting the D-Bus names of portals, or something implemented inside the portals themselves.

rusty-snake · 2020-05-02T10:16:18Z

From my side we could merge.

glitsj16 · 2020-05-02T18:00:43Z

From my side we could merge.

@rusty-snake LGTM. Great work and a big thank you to all involved!

* use the new dbus format in chromium-common.profile * use new dbus format in firejail.config Now that #3326 landed I think it might be less confusing to keep using the --nodbus wording. Couldn't come up with a better alternative (yet), so this might need future improvements. * block dbus system bus Blocking the system bus shouldn't affect password functionality etc, as that uses the session bus.

Relates to netblue30#3326 netblue30#6285 netblue30#6444.

kris7t reviewed Apr 7, 2020

View reviewed changes

glitsj16 reviewed Apr 7, 2020

View reviewed changes

rusty-snake force-pushed the dbus-filter-profiles branch from 913b373 to 8ab4ab5 Compare April 8, 2020 06:45

glitsj16 added a commit that referenced this pull request Apr 8, 2020

add example for overriding individiual DBus filter to firejail-profil…

41d4e3d

…e.txt See discussion in #3326.

rusty-snake added 5 commits May 1, 2020 09:31

dbus filter (1)

eb4f33c

dbus-filter: firefox

a7b4adb

drop org.gtk.vfs and com.canonical.AppMenu.Registrar [skip ci]

7b9e5e0

9efdd63

[skip ci]

cedc7da

rusty-snake force-pushed the dbus-filter-profiles branch from 7f4679c to cedc7da Compare May 1, 2020 10:48

glitsj16 mentioned this pull request May 1, 2020

qtox is missing from system tray #3392

Closed

rusty-snake merged commit 8744e08 into netblue30:master May 2, 2020

rusty-snake deleted the dbus-filter-profiles branch May 2, 2020 18:05

kris7t mentioned this pull request May 7, 2020

DBus filtering enhancements #3406

Merged

glitsj16 mentioned this pull request Jun 18, 2020

Properly document how to "Drastically reduce security for profiles which need to open stuff in [browser name]" #3471

Open

matu3ba mentioned this pull request Oct 7, 2021

luarocks matu3ba/firejail#1

Closed

kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 28, 2024

profiles: firefox-common: centralize dbus comments

21a5775

Relates to netblue30#3326 netblue30#6285 netblue30#6444.

kmk3 mentioned this pull request Sep 28, 2024

profiles: browsers: centralize/sync/improve comments #6486

Merged

kmk3 changed the title ~~dbus filter profiles (1)~~ profiles: add dbus filters Sep 28, 2024

profiles: add dbus filters #3326

profiles: add dbus filters #3326

Conversation

rusty-snake commented Apr 7, 2020 • edited Loading

rusty-snake commented Apr 7, 2020

kris7t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kris7t commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kris7t Apr 7, 2020 • edited Loading

Choose a reason for hiding this comment

Fred-Barclay commented Apr 7, 2020

rusty-snake commented Apr 7, 2020

Fred-Barclay commented Apr 7, 2020

rusty-snake commented Apr 7, 2020

Fred-Barclay commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glitsj16 commented Apr 8, 2020 • edited Loading

rusty-snake commented Apr 11, 2020

Fred-Barclay commented Apr 11, 2020

rusty-snake commented Apr 11, 2020

glitsj16 commented Apr 11, 2020

rusty-snake commented Apr 11, 2020

kris7t commented Apr 11, 2020 • edited Loading

rusty-snake commented Apr 11, 2020

glitsj16 commented Apr 11, 2020

rusty-snake commented Apr 12, 2020

kris7t commented Apr 13, 2020

rusty-snake commented May 2, 2020

glitsj16 commented May 2, 2020

rusty-snake commented Apr 7, 2020 •

edited

Loading

kris7t Apr 7, 2020 •

edited

Loading

glitsj16 commented Apr 8, 2020 •

edited

Loading

kris7t commented Apr 11, 2020 •

edited

Loading