Skip to content

Commit

Permalink
Follow-up for #3326 (#3397)
Browse files Browse the repository at this point in the history
* use the new dbus format in chromium-common.profile

* use new dbus format in firejail.config

Now that #3326 landed I think it might be less confusing to keep using the --nodbus wording. Couldn't come up with a better alternative (yet), so this might need future improvements.

* block dbus system bus

Blocking the system bus shouldn't affect password functionality etc, as that uses the session bus.
  • Loading branch information
glitsj16 authored May 4, 2020
1 parent b69ce6a commit 276f250
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion etc/firejail.config
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# Enable or disable chroot support, default enabled.
# chroot yes

# Enable or disable dbus handling by --nodbus flag, default enabled.
# Enable or disable dbus handling, default enabled.
# dbus yes

# Disable /mnt, /media, /run/mount and /run/media access. By default access
Expand Down
5 changes: 4 additions & 1 deletion etc/profile-a-l/chromium-common.profile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ include whitelist-var-common.inc
apparmor
caps.keep sys_admin,sys_chroot
netfilter
# nodbus - prevents access to passwords saved in GNOME Keyring and KWallet, also breaks Gnome connector
nodvd
nogroups
notv
Expand All @@ -40,5 +39,9 @@ disable-mnt
?BROWSER_DISABLE_U2F: private-dev
# private-tmp - problems with multiple browser sessions

# prevents access to passwords saved in GNOME Keyring and KWallet, also breaks Gnome connector
# dbus-user none
dbus-system none

# the file dialog needs to work without d-bus
?HAS_NODBUS: env NO_CHROME_KDE_FILE_DIALOG=1

0 comments on commit 276f250

Please sign in to comment.