Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: firefox: add org.kde.kdeconnect to plasma comment #6285

Merged

Conversation

RundownRhino
Copy link
Contributor

Turning this into a PR as per #1139 (comment).

I recently set up KDE connect and plasma-browser-integration for firefox (Linux Mint 21.2) and needed this line in addition to the ones mentioned in the profile. Found it via running firejail --profile=/etc/firejail/firefox.profile --dbus-user.log firefox, trying to send links to device, and seeing what events get logged.

(I also needed ignore dbus-user none in firefox-common.local, which is mentioned in a comment already. I'm not using private-bin for firefox.)

Ideally I'd want someone to test this and confirm they also require this line for plasma-browser-integration to work; possibly it's platform- or version-specific.

@kmk3 kmk3 changed the title Add dbus-user.talk org.kde.kdeconnect to plasma-browser-integration for firefox firefox: Add org.kde.kdeconnect to plasma integration comment Mar 23, 2024
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently set up KDE connect and plasma-browser-integration for firefox
(Linux Mint 21.2) and needed this line in addition to the ones mentioned
in the profile. Found it via running `firejail
--profile=/etc/firejail/firefox.profile --dbus-user.log firefox`, trying
to send links to device, and seeing what events get logged.
@kmk3 kmk3 force-pushed the firefox-plasma-integration-fix branch from 8bbe3b4 to 12f48e2 Compare March 23, 2024 12:27
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the details.

@kmk3
Copy link
Collaborator

kmk3 commented Mar 23, 2024

I recently set up KDE connect and plasma-browser-integration for firefox
(Linux Mint 21.2) and needed this line in addition to the ones mentioned in
the profile.

Ideally I'd want someone to test this and confirm they also require this line
for plasma-browser-integration to work; possibly it's platform- or
version-specific.

The dbus name is directly related to the service being used (KDE Connect) and
Mint is a rather common distribution so I don't see why having this line would
be an issue.

@glitsj16 glitsj16 merged commit 009212b into netblue30:master Mar 24, 2024
3 checks passed
@kmk3 kmk3 changed the title firefox: Add org.kde.kdeconnect to plasma integration comment profiles: firefox: add org.kde.kdeconnect to plasma comment Sep 7, 2024
kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 25, 2024
kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 25, 2024
kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 25, 2024
kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants