fix: Hot/cold combination of a wallet doesn't work smooth #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devchenyan
requested review from
yanguoyu,
Keith-CY and
WhiteMinds
and removed request for
Keith-CY and
yanguoyu
Keith-CY
reviewed
Dec 24, 2023
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
yanguoyu
reviewed
Dec 27, 2023
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
|
Any update on the conversations above? |
yanguoyu
reviewed
Jan 8, 2024
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
Keith-CY
reviewed
Jan 11, 2024
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
Keith-CY
reviewed
Jan 13, 2024
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/BroadcastTransaction/index.tsx
Outdated
Show resolved
Hide resolved
yanguoyu
reviewed
Jan 14, 2024
yanguoyu
approved these changes
Jan 14, 2024
Keith-CY
approved these changes
Jan 14, 2024
|
/package |
|
/package |
|
/package |
|
1.Why not calls unsigned transaction here? |
This was suggested to be revised in the above comment. |
silySuper
approved these changes
Jan 29, 2024
yanguoyu
pushed a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
…ork#3000) * fix: issue 288 * fix: broadcastTransaction * fix: BroadcastTransaction * fix: French * fix: broadcastTransactionOnly * fix: comments * fix: broadcastSignedTransaction * fix * feat: remove Wallet field --------- Co-authored-by: Chen Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: Magickbase/neuron-public-issues#288
Screen-2024-01-01-235512.mp4