Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot/cold combination of a wallet doesn't work smooth #288

Open
Keith-CY opened this issue Sep 25, 2023 · 9 comments
Open

Hot/cold combination of a wallet doesn't work smooth #288

Keith-CY opened this issue Sep 25, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Here is the case

  1. Create a wallet in an offline computer as the cold wallet
  2. Export extended public key from the cold wallet
  3. Import extended public key in an online computer as the hot wallet
  4. Export an unsigned transaction from the hot wallet
  5. Import the unsigned transaction in the cold wallet and sign&export
  6. Try to import the signed transaction to broadcast in the hot wallet, failed due to the disabled offline sign menu item, because of https://github.com/nervosnetwork/neuron/blob/f2f57087f3865096c7d485b6de40df5ef11d772a/packages/neuron-wallet/src/controllers/app/menu.ts#L354, it's disabled when the wallet is a watching wallet

Workaround: create a transient wallet to enable the offline-sign menu item to accept the signed transaction.


We should find a better workflow for the combination of cold/hot wallets.

@Keith-CY Keith-CY added the enhancement New feature or request label Sep 25, 2023
@Keith-CY Keith-CY added this to Neuron Sep 25, 2023
@Danie0918 Danie0918 moved this to 📌Planning in Neuron Sep 25, 2023
@Danie0918
Copy link
Contributor

PRD

【Optimization of hot/cold combinations for wallets】

  • Requirement Description:The combination of hot/cold in the wallet is not smooth and the workflow needs to be optimized.

optimization_of_hot_cold_combinations_for_wallets

  • Requirement Contents
  1. Offline signing is not being supported to import signed transactions and to close the pop-up window when the signature is complete.
  2. Added broadcast transaction:
  • Unable to select when offline, support for watch-only account broadcasting.
  • The broadcast shows the loading status and jumps to history when finished.
  1. Pop-up window alert:
  • Import signed transaction files in Offline Signature.
  • Import unsigned transaction files in broadcast transaction.

@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Oct 24, 2023
@yanguoyu
Copy link

  1. [Optimization of hot/cold combinations for wallets] Added broadcast transaction:
    support for watch-only account broadcasting.

I believe broadcast transactions can be for any wallet, but not a watch-only account.

@Danie0918
Copy link
Contributor

  1. [Optimization of hot/cold combinations for wallets] Added broadcast transaction:
    support for watch-only account broadcasting.

I believe broadcast transactions can be for any wallet, but not a watch-only account.

In that case, the user would still need to create a separate wallet to do so.Does this meet expectations? @Keith-CY

@yanguoyu
Copy link

  1. [Optimization of hot/cold combinations for wallets] Added broadcast transaction:
    support for watch-only account broadcasting.

I believe broadcast transactions can be for any wallet, but not a watch-only account.

In that case, the user would still need to create a separate wallet to do so.Does this meet expectations? @Keith-CY

My mistake, I mean works for any wallet, not only limited to work with a watched-only account. @Danie0918

@Danie0918
Copy link
Contributor

  1. [Optimization of hot/cold combinations for wallets] Added broadcast transaction:
    support for watch-only account broadcasting.

I believe broadcast transactions can be for any wallet, but not a watch-only account.

In that case, the user would still need to create a separate wallet to do so.Does this meet expectations? @Keith-CY

My mistake, I mean works for any wallet, not only limited to work with a watched-only account. @Danie0918

Okay, this is as expected.

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 22, 2023

Sorry for replying late.

These two sub-items offline sign and broadcast transaction can be merged into one.

If the wallet is able to sign, show offline sign
If the wallet is unable to sign, show broadcast transaction

@devchenyan
Copy link

fixed: nervosnetwork/neuron#3000

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Dec 29, 2023
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Jan 15, 2024
@Danie0918 Danie0918 assigned silySuper and unassigned devchenyan Jan 15, 2024
@silySuper
Copy link

verified

@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Jan 30, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

6 participants