-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multisig address list is abnormal #347
Comments
Notice the address ends with |
Possibly caused by https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/controllers/multisig.ts#L82 and https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/controllers/multisig.ts#L90 The multisig config is bound to a specific wallet, so launching with different wallets loads different configs I would suggest an optimization as follows:
BTW, similar logic appears at nervosnetwork/neuron#3000 (comment) so we should highlight the rules in PRD to reduce the barrier of understanding |
I guess it's normal, in the previous the multisig config was designed to bind to the wallet. We can change it to bind to the global, but we should not filter the multisig address if every address of the multisig config does not belong to the current wallet, because someone wants to monitor the multisig address and create a transaction without the sign. |
Reproducible, but wallets A, B, C should all be in Neuron.
Otherwise
Screen.Recording.2023-12-30.at.16.02.51.mov
The text was updated successfully, but these errors were encountered: