BUGFIX: CreationDialog hideable elements #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduces logic to evaluate
```yaml
ui:
creationDialog:
elements:
hiddenProperty:
type: string
ui:
hidden: true
```
clientEval is working out of the box, since the configuration has been evaluated with `preprocessNodeConfiguration`
mhsdesign
added a commit
to neos/neos-development-collection
that referenced
this pull request
May 28, 2023
In the UI it will be once neos/neos-ui#3507 is merged possible to use the `hidden` property in the node creation dialog ```yaml ui: creationDialog: elements: hiddenProperty: type: string ui: hidden: true ``` This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via `showInCreationDialog` will have the hidden property copied ```yaml properties: hiddenProperty: type: string ui: showInCreationDialog: true inspector: hidden: true ```
6 tasks
|
someone should try it with 7.3 (and webpack) i just backportet it from 8.3 |
|
Tried in 7.3 and works 👍 |
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Sep 8, 2023
In the UI it will be once neos/neos-ui#3507 is merged possible to use the `hidden` property in the node creation dialog ```yaml ui: creationDialog: elements: hiddenProperty: type: string ui: hidden: true ``` This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via `showInCreationDialog` will have the hidden property copied ```yaml properties: hiddenProperty: type: string ui: showInCreationDialog: true inspector: hidden: true ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes partially (the ui part) #3483
optional neos part for support of
showInCreationDialog: neos/neos-development-collection#4297introduces logic to evaluate
clientEval is working out of the box, since the configuration has been evaluated with
preprocessNodeConfigurationBildschirmaufnahme.2023-05-28.um.09.59.31.mov
What I did
How I did it
How to verify it
test it with this (or your own) nodeType.
Note that creationDialog items that are generated from properties via
showInCreationDialogwill not yet have the hidden property copied, for this a fix in neos/neos has to be done (neos/neos-development-collection#4297)