BUGFIX: CreationDialog hideable elements #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the UI it will be once neos/neos-ui#3507 is merged possible to use the `hidden` property in the node creation dialog ```yaml ui: creationDialog: elements: hiddenProperty: type: string ui: hidden: true ``` This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via `showInCreationDialog` will have the hidden property copied ```yaml properties: hiddenProperty: type: string ui: showInCreationDialog: true inspector: hidden: true ```
|
Can you check the StyleCI issue? @mhsdesign |
|
nope i cant the style ci is just running maniac. i dindt touch the files. |
You can fix the issue anyway? |
|
nope that will cause a lot of issues if its done as bugfix into 7.3 imo someone should just reconfigure the style ci. it should not be part of this pr. |
crydotsnake
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Tested in combination with neos/neos-ui#3507 and works as expected!
Sebobo
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes cross repo issue: neos/neos-ui#3483
In the UI it will be once neos/neos-ui#3507 is merged possible to use the
hiddenproperty in the node creation dialogThis change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via
showInCreationDialogwill have the hidden property copiedUpgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions