Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add some ClientEval functionality in nodeCreationDialog #3344

Conversation

FahimNsr
Copy link
Contributor

@FahimNsr FahimNsr commented Jan 26, 2023

What I did

I bring some ClientEval functionality into nodeCreationDialog.

How I did it

Because in the nodeCreationDialog step, the node doesn't create yet I build an artificial Node Object in the State of nodeCreationDialog Modal, which helps us to get the value of each node.properties and then I used the preprocessViewConfiguration function that's almost similar to the function that we used in Inspector, to set the right value and configuration in nodeCreationDialog.

How to verify it

I upload a video to help to better understand.

Screen.Recording.2023-02-01.at.11.57.42.mov

@FahimNsr FahimNsr changed the title Feature: add some ClientEval functionality in nodeCreationDialog WIP: Feature: add some ClientEval functionality in nodeCreationDialog Jan 26, 2023
@FahimNsr FahimNsr force-pushed the Featute/Eval-Funktionality-for-CreationDialog branch from 8adf6e6 to 8ac0dc8 Compare February 1, 2023 10:30
@FahimNsr FahimNsr changed the title WIP: Feature: add some ClientEval functionality in nodeCreationDialog Feature: add some ClientEval functionality in nodeCreationDialog Feb 1, 2023
@crydotsnake crydotsnake changed the title Feature: add some ClientEval functionality in nodeCreationDialog FEATURE: add some ClientEval functionality in nodeCreationDialog Feb 11, 2023
@crydotsnake crydotsnake added Feature Label to mark the change as feature 8.3 labels Feb 11, 2023
@JamesAlias
Copy link
Contributor

JamesAlias commented Feb 14, 2023

This has actually been worked on by the community in the Neos Coding Live Stream 😅

see #3304

I'm in the process of cleaning our MR up and then it would be ready to merge as well.

@FahimNsr
Copy link
Contributor Author

FahimNsr commented Mar 2, 2023

This has actually been worked on by the community in the Neos Coding Live Stream 😅

see #3304

I'm in the process of cleaning our MR up and then it would be ready to merge as well.

Hi @JamesAlias ,

I saw your PR, and that was very nice that you add the dependency on the Parent node.

I would to mention that as you can see in the video I fixed the hidden property for NodeCreationDialog in my PR with some configuration in 2 different ways.

  1. we can get the hidden property of Inspector and set the same value for NodeCreationDialog in this File. (lines 123-125)

Packages/Neos/Neos.Neos/Classes/NodeTypePostprocessor/CreationDialogPostprocessor.php

Screenshot 2023-03-02 at 09 59 03

or

  1. we can set this config in yaml for the email property (as you see in the Video) (lines 8-13)

Screenshot 2023-03-02 at 09 57 20

@Sebobo @grebaldi, I would to know your opinion too about this hidden Property.

@mhsdesign
Copy link
Member

Hi @FahimNsr we fixed #3483 (that hidden doesnt work in the node creation dialog)

now with #3507 and neos/neos-development-collection#4297

so i think we can close your pr?

Thanks for your effort!

@c4ll-m3-j4ck c4ll-m3-j4ck deleted the Featute/Eval-Funktionality-for-CreationDialog branch August 18, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Feature Label to mark the change as feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants