TASK: Adding labels to PRs #3387
Conversation
|
Guess will add this to the other repos (flow and neos) as well... |
|
Ok that it works, is visible in the feed. |
|
What about changing the target branch afterwards? This we would do manually? |
Then I need to read the event docs of github actions again ;) |
|
Until the runner supports the remove all labels, I will skip that. And I don't want to maintain another custom library ;) So when this will work anytime. We can remove all labels and readd the matching ones. |
|
Can we also make a rename action so when I write |
markusguenther
force-pushed
the
task/add-pr-labeler
branch
from
1b51dae
to
8c729ea
Compare
|
|
Work on that, but comes with another PR and actually not finished. |
|
Ok now the PR is working perfect and we cannot remove labels accidentally |
|
Should we add this to the lowest maintained branch? Or are we fine with adding it to 8.3 and above? |
|
Hmm good point @ahaeslich |
With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time. We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we als add the bugfix, task or feature label.
markusguenther
force-pushed
the
task/add-pr-labeler
branch
from
578b7db
to
6c9ca3b
Compare
|
Rebase is done ;) @ahaeslich |
With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time. *What I did* We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the bugfix, task or feature label. *How I did it* I use the runner from https://github.com/actions-ecosystem They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways. *How to verify it* Checkout how it works in the neos-ui. neos/neos-ui#3387
With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time. *What I did* We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the bugfix, task or feature label. *How I did it* I use the runner from https://github.com/actions-ecosystem They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways. *How to verify it* Checkout how it works in the neos-ui. neos/neos-ui#3387 **Checklist** - [x] The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html) - [ ] Reviewer - PR Title is brief but complete and starts with `FEATURE|TASK|BUGFIX` - [ ] Reviewer - The first section explains the change briefly for change-logs - [ ] Reviewer - Breaking Changes are marked with `!!!` and have upgrade-instructions
With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time.
What I did
We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the
bugfix,taskorfeaturelabel.How I did it
I use the runner from https://github.com/actions-ecosystem
They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways.
How to verify it
https://github.com/Unikka/neos-ui-new/actions/runs/4217847523