Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Adding labels to PRs #4045

Merged
merged 1 commit into from
Feb 22, 2023
Merged

TASK: Adding labels to PRs #4045

merged 1 commit into from
Feb 22, 2023

Conversation

markusguenther
Copy link
Member

@markusguenther markusguenther commented Feb 20, 2023

With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time.

What I did
We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the bugfix, task or feature label.

How I did it
I use the runner from https://github.com/actions-ecosystem They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways.

How to verify it
Checkout how it works in the neos-ui.
neos/neos-ui#3387

Checklist

  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions


With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time.

*What I did*
We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the bugfix, task or feature label.

*How I did it*
I use the runner from https://github.com/actions-ecosystem
They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways.

*How to verify it*
Checkout how it works in the neos-ui.
neos/neos-ui#3387
@markusguenther
Copy link
Member Author

BTW: It would also be possible to add more labels like the JavaScript label via bot.

@markusguenther markusguenther merged commit 20b2e68 into 7.3 Feb 22, 2023
@markusguenther markusguenther deleted the tasks/add-labels-to-prs branch February 22, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants