TASK: Adding labels to PRs #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time. *What I did* We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the bugfix, task or feature label. *How I did it* I use the runner from https://github.com/actions-ecosystem They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways. *How to verify it* Checkout how it works in the neos-ui. neos/neos-ui#3387 **Checklist** - [x] The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html) - [ ] Reviewer - PR Title is brief but complete and starts with `FEATURE|TASK|BUGFIX` - [ ] Reviewer - The first section explains the change briefly for change-logs - [ ] Reviewer - Breaking Changes are marked with `!!!` and have upgrade-instructions
ahaeslich
approved these changes
Feb 20, 2023
|
Hmm, the failing psalm test is not related |
crydotsnake
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this task, we add automatically labels to the PRs. That makes the maintaining easier, as we did that manually all the time.
What I did
We always add the target branch as label, so we see directly which version the PR targets. And if the Commit message is following our rules, we also add the bugfix, task or feature label.
How I did it
I use the runner from https://github.com/actions-ecosystem They use node 12 which leads to a warning as actions are running node 16 but an issue is created and it runs anyways.
How to verify it
Checkout how it works in the neos-ui.
neos/neos-ui#3387
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions