Preview4 Checklist

[superboyiii]

Neo3-preview4 Release Checklist

Now We're preparing the checklist of neo3-preview4 for task collection. We've already focused on these issues and PRs but we're also glad to collect other requirements. This checklist will be frozen on Dec 7th, then we'll work on these.
This release should be on 12/15 2020 (Can be moved forward if completed ahead). Then Preview4 testnet will be launched. And two weeks later, we will release neo-cli v3.0.0 and launch neo3 testnet. Formal testnet will nearly the same as Preview4 testnet, but chain data and seed nodes will be reset. Now we're focusing on these issues and PRs.

Since more PRs and Issues are coming to Checklist, we delay the release time for three weeks(12/15 2020)

Mandatory issues

• Redefine opcode prices Redefine opcode prices and make them adjustable #1875
  how to sign state root message How to sign the stateroot？ #1526 (will be fixed after Preview4)
• Update TransactionManager to support magic parameter Update TransactionManager to support magic parameter neo-modules#343
• OnPersist and PostPersist have the same application log hash OnPersist and PostPersist have the same application log hash neo-modules#354
• Remove sender from invoke* RPCs Remove sender from invoke* RPCs neo-modules#351
• Encode scripts in base64 Encode scripts in base64 neo-modules#337
• Expand getversion RPC call output with network's magic number Expand getversion RPC call output with network's magic number neo-modules#358
  REQ: RPC call with Verification trigger type REQ: RPC call with Verification trigger type #1977 (will be fixed after Preview4)
• Return FaultException for invokefunction and invokescript RPC calls Return FaultException for invokefunction and invokescript RPC calls neo-modules#334
• validateaddress should not accept hexs, or should it? validateaddress should not accept hexs, or should it? neo-modules#352
• Non-asset signer in invokefunction should not be able to create tx automatically and should not be in the list of signers. Non-asset signer in invokefunction should not be able to create tx automatically and should not be in the list of signers. neo-modules#370
• neo-cli isn't able to show exception msg from Smart Contract but just show Error neo-cli isn't able to show exception msg from Smart Contract but just show Error  neo-node#672
• Redefine Opcode/Syscall price Redefine Opcode/Syscall price #2004
• Querying contracts by ID/name, server side Querying contracts by ID/name, server side neo-modules#355
• Keep the hash unchanged when upgrading contracts Keep the hash unchanged when upgrading contracts #2021

Mandatory PRs

• Add incentive for voter Add incentive for voter #1848
• Add incentive for committee Add incentive for committee #1847
• Add incentive for NEO holder Add incentive for neo holders #1845
• Recalculate committee every 28 blocks Recalculate committee every 28 blocks #1907
• Asynchronous oracle Asynchronous Oracle #1738
• Add UInt160, UInt256 and ECPoint to SmartContract Framework Add UInt160, UInt256 and ECPoint to SmartContract Framework neo-devpack-dotnet#362
  Oracle plugin OracleService neo-modules#326
  Allow oracle to access NeoFS
• Compiler support for asynchronous oracle Asynchronous Oracle neo-devpack-dotnet#337
• Add GetCommittee RPC method Add Getcommittee neo-modules#342
• Update dependencies Update dependencies neo-modules#338
• Pure async RpcClient Pure async RpcClient neo-modules#335
• Remove sender from invoke method Remove sender from invoke method neo-modules#368
• invoke* use base64 script invoke* use base64 script neo-modules#362
• Add magic field in getversion Add magic field in getversion neo-modules#363
• Add exception field in invokeresult Add exception field in invokeresult neo-modules#364
• Fix validateaddress Fix validateaddress neo-modules#365
• Update contract without change the hash Update contract without change the hash #2044
• Fix native serialize Fix native serialize #1988
• Keeping up to date with neo: trigger type trigger type for getapplicationlog neo-modules#380
• Fix sync issue Fix sync issue #2031
  Fix GAS initialize Fix GAS initialize #2006 (will be fixed in v3.0.0 due to the total amount of that time)
  Optimize gas storage Optimize gas storage #1987 (will be fixed after Preview4)
  Add Fee Ratio Add Fee Ratio #2032
• Fixed some opcode price Fixed some opcode price #2020
• Make BinarySerializer public Make BinarySerializer public #2041
• Sync neo changes Sync neo changes neo-devpack-dotnet#391
• Implement NEP-17 Implement NEP-17 #2024
• Update RpcServer.SmartContract.cs [RpcServer] Update RpcServer.SmartContract.cs neo-modules#400
• Update LogReader.cs Update LogReader.cs neo-modules#401
• SmartContract/Native: implement adjustable opcode pricing SmartContract/Native: implement adjustable opcode pricing #2045
• Centralize _initialize call Centralize _initialize call #2052
• Create ManagementContract Create ManagementContract #2119
• Sync update with neo pull 2119 Sync update with neo pull 2119 neo-devpack-dotnet#402
• Sync to management SC Sync to management SC neo-node#689
• Sync to management SC Sync to management SC neo-modules#418
  @neo-project/developers @neo-project/core @neo-project/ngd-seattle

[devhawk]

Can we include neo-project/neo-modules#335 plus a fix for neo-project/neo-modules#343 in preview 4? Once 335 PR is in, I can do the work to fix 343 very quickly.

[vncoelho]

Looks good @superboyiii.
I agree with those two PRs, @devhawk, if you need any support let me know.

[vncoelho]

Who will proceed with "Allow oracle to access NeoFS", @roman-khimov @neo-project/ngd-shanghai? The template for the asynchronous has been merged. Will it come after we merge neo-project/neo-modules#326 or you are already preparing it?

[Tommo-L]

Who will proceed with "Allow oracle to access NeoFS", @roman-khimov @neo-project/ngd-shanghai? The template for the asynchronous has been merged. Will it come after we merge neo-project/neo-modules#326 or you are already preparing it?

We'll add this feature after neo-project/neo-modules#326 merged.

[devhawk]

I agree with those two PRs, @devhawk, if you need any support let me know.

FYI @vncoelho I had linked to the wrong PRs - the ones I was mentioning are in modules repo

[vncoelho]

Then I need to double check...aehuahuea The async RPC looks good in my opinion but not necessarily a feature that we need right now. But if you have in mind a good way to distribute its loads it would be good if it can come asap.

[devhawk]

Then I need to double check...aehuahuea The async RPC looks good in my opinion but not necessarily a feature that we need right now. But if you have in mind a good way to distribute its loads it would be good if it can come asap.

You might not need it, but neo express does.

[vncoelho]

If it is a requirement perhaps it should be included.

[devhawk]

We should have a simple Oracles sample for preview 4 developers

[devhawk]

Can we include neo-project/neo-devpack-dotnet#362 in checklist for preview 4?

[superboyiii]

Can we include neo-project/neo-modules#335 plus a fix for neo-project/neo-modules#343 in preview 4? Once 335 PR is in, I can do the work to fix 343 very quickly.

Done.

[superboyiii]

Can we include neo-project/neo-devpack-dotnet#362 in checklist for preview 4?

Done.

[devhawk]

FYI @superboyiii I added the fix for neo-project/neo-modules#343 to neo-project/neo-modules#335

[roman-khimov]

IIUC preview4 is supposed to have broader support from various community projects, especially ones that are more developer- and user-oriented, like compilers, wallets, light nodes and alike. These tend to care more about external interfaces provided by the node rather than internal improvements, thus I'd like to raise priority for some of the issues related to these external node interfaces.

neo-project/neo-modules#354 --- this one is a MUST before preview4 to me
neo-project/neo-modules#351, neo-project/neo-modules#337 --- affecting frequently used APIs, better deal with them now than leave post-preview4
neo-project/neo-modules#358, neo-project/neo-modules#355, #1977 --- these are very important for some RPC clients
neo-project/neo-modules#334 --- minor, but easy to fix and helps a lot
neo-project/neo-modules#352 --- minor, but easy to fix

[superboyiii]

IIUC preview4 is supposed to have broader support from various community projects, especially ones that are more developer- and user-oriented, like compilers, wallets, light nodes and alike. These tend to care more about external interfaces provided by the node rather than internal improvements, thus I'd like to raise priority for some of the issues related to these external node interfaces.

neo-project/neo-modules#354 --- this one is a MUST before preview4 to me
neo-project/neo-modules#351, neo-project/neo-modules#337 --- affecting frequently used APIs, better deal with them now than leave post-preview4
neo-project/neo-modules#358, neo-project/neo-modules#355, #1977 --- these are very important for some RPC clients
neo-project/neo-modules#334 --- minor, but easy to fix and helps a lot
neo-project/neo-modules#352 --- minor, but easy to fix

All these are added.

[Tommo-L]

Add #1973, as it's imcompatible.

[superboyiii]

Add #1973, as it's imcompatible.

Done.

[devhawk]

Any chance of including #1966 in preview 4?

[devhawk]

Is preview 4 the last chance for breaking changes? i.e. will we be able to consider making more changes for #1866 after preview 4? (such as #1952 and neo-project/neo-devpack-dotnet#371)

[superboyiii]

Any chance of including #1966 in preview 4?

Sorry, Harry. This PR is excellent but it has made huge changes, maybe we could merge it to neo-core after neo v3.0.0 released and review it step by step.

Is preview 4 the last chance for breaking changes? i.e. will we be able to consider making more changes for #1866 after preview 4? (such as #1952 and neo-project/neo-devpack-dotnet#371)

We could take it into neo-core between preivew4 and neo v3.0.0.

[roman-khimov]

All these are added.

Hmm, I don't see neo-project/neo-modules#355 there, any particular reason for that?

[devhawk]

Any chance of including #1966 in preview 4?

Sorry, Harry. This PR is excellent but it has made huge changes, maybe we could merge it to neo-core after neo v3.0.0 released and review it step by step.

Is preview 4 the last chance for breaking changes? i.e. will we be able to consider making more changes for #1866 after preview 4? (such as #1952 and neo-project/neo-devpack-dotnet#371)

We could take it into neo-core between preivew4 and neo v3.0.0.

#1966 has changes related to #1866 (i.e. domain model unification) and #1865 (domain model decoupling). I'm much more concerned about getting changes related to unification in before shipping v3 than decoupling. Can we do a post preview 4 PR to move types like Block and Transaction to the Neo.Models namespace?

[superboyiii]

Any chance of including #1966 in preview 4?

Sorry, Harry. This PR is excellent but it has made huge changes, maybe we could merge it to neo-core after neo v3.0.0 released and review it step by step.

Is preview 4 the last chance for breaking changes? i.e. will we be able to consider making more changes for #1866 after preview 4? (such as #1952 and neo-project/neo-devpack-dotnet#371)

We could take it into neo-core between preivew4 and neo v3.0.0.

#1966 has changes related to #1866 (i.e. domain model unification) and #1865 (domain model decoupling). I'm much more concerned about getting changes related to unification in before shipping v3 than decoupling. Can we do a post preview 4 PR to move types like Block and Transaction to the Neo.Models namespace?

@shargon @erikzhang What's your opinion?

[superboyiii]

All these are added.

Hmm, I don't see neo-project/neo-modules#355 there, any particular reason for that?

A mis, add it back now.

[devhawk]

#2041 is quite simple (makes BinarySerializer class public). Can we include this in preview 4?

[superboyiii]

#2041 is quite simple (makes BinarySerializer class public). Can we include this in preview 4?

Sure.

[devhawk]

@superboyiii I believe neo-project/neo-modules#385 is a must fix for preview 4. Invoke script RPC method script parameter handling doesn't match between RpcClient and RpcServer

[superboyiii]

@superboyiii I believe neo-project/neo-modules#385 is a must fix for preview 4. Invoke script RPC method script parameter handling doesn't match between RpcClient and RpcServer

Fixed in neo-project/neo-modules#386

[devhawk]

Are we switching to net5.0 target framework across the whole neo project? If so, is this going to be in preview 4? If we make that switch in Neo.VM, that means all downstream projects have to switch as well. I tried pulling the neo.vm change into https://github.com/devhawk/neo-monorepo and none of the downstream projects compile anymore.

[shargon]

Are we switching to net5.0 target framework across the whole neo project?

I think that is not for preview 4

[devhawk]

Are we switching to net5.0 target framework across the whole neo project?

I think that is not for preview 4

the net5.0 change has already been made in neo-vm project. So is the plan to create a preview 4 fork at the commit before the change was made?

[devhawk]

I think this needs to be fixed for preview 4: https://github.com/neo-project/neo/issues/2072

[Tommo-L]

I think we'd better review and merge this two incompatible PRs first. #2044 #2056

[ProDog]

I think we'd better review and merge this two incompatible PRs first. #2044 #2056

#2044 need neo-project/neo-devpack-dotnet#388 and neo-project/neo-devpack-dotnet#391, I think we can review and merge it as soon as possible, then test it together.

[shargon]

neo-project/neo-devpack-dotnet#388 will be replaced by neo-project/neo-devpack-dotnet#391

[devhawk]

#2085 looks like another issue that needs to be fixed for preview 4, but given the in-flight state of some of the NEP-17 related stuff, a fix for this might already be waiting to merge.

[lock9]

Hello,
There are a few items not checked on this list. Is the release date going to be postponed?

[devhawk]

I hate to add to this list, but #2151 needs to be fixed for preview 4.

I can work around #2151 in neo express by calling setMinimumDeploymentFee, but I think this should be fixed for preview 4

[kelimelogg]

is it delayed again? adverse situation for the investor

[lock9]

@kelimelogg There are always some delays on software projects, but you shouldn't worry, they are delaying it because they want to make it right. It is a healthy delay.

[PsychedelicHell]

Please release Neo3 so I can sell.

[kelimelogg]

what else is expected?