Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neo master branch can't load contract manifest generated by neon master branch #394

Closed
devhawk opened this issue Nov 18, 2020 · 1 comment
Closed

Neo master branch can't load contract manifest generated by neon master branch #394

devhawk opened this issue Nov 18, 2020 · 1 comment
Assignees
@shargon

Comments

@devhawk
Copy link
Contributor

devhawk commented Nov 18, 2020

Describe the bug
ContractManifest.DeserializeFromJson is expecting the manifest JSON to have a name property. FuncExport.GenerateManifest in https://github.com/neo-project/neo-devpack-dotnet does not create a name property

To Reproduce
Steps to reproduce the behavior:

  1. compile contract with neon master branch
  2. Attempt to parse the contract manifest

Expected behavior
ContractManifest.DeserializeFromJson should not throw

Platform:

  • OS: Windows
  • Version neo master branch + neo-devpack-dotnet master branch
@shargon shargon self-assigned this Nov 19, 2020
@shargon shargon transferred this issue from neo-project/neo Nov 19, 2020
@shargon
Copy link
Member

shargon commented Nov 19, 2020 •
edited
Loading

I think that it will be fixed by #391

@shargon shargon closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shargon shargon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devhawk @shargon