InvokeScript RpcClient sending Base64 but RpcServer expecting Hex

[devhawk]

Describe the bug
Script format mismatch between RpcClient and RpcServer

I believe this is a MUST FIX for preview 4

RpcClient passes script parameter as string after calling Convert.ToBase64String(script)

public async Task<RpcInvokeResult> InvokeScriptAsync(byte[] script, params Signer[] signers)
{
    List<JObject> parameters = new List<JObject> { Convert.ToBase64String(script) };
    if (signers.Length > 0)
    {
        parameters.Add(signers.Select(p => p.ToJson()).ToArray());
    }
    var result = await RpcSendAsync(GetRpcName(), parameters.ToArray()).ConfigureAwait(false);
    return RpcInvokeResult.FromJson(result);
}

RpcServer attempts to parse the script parameter via HexToBytes

[RpcMethod]
protected virtual JObject InvokeScript(JArray _params)
{
    byte[] script = _params[0].AsString().HexToBytes();
    Signers signers = _params.Count >= 2 ? SignersFromJson((JArray)_params[1]) : null;
    return GetInvokeResult(script, signers);
}

[roman-khimov]

RpcServer was converted to using base64 in #362, but then it looks like the old code was partially reintroduced with #368. What's really weird is that this wasn't caught by any unit test.

[devhawk]

I confirmed that changing the first line of RpcServer InvokeScript to byte[] script = Convert.FromBase64String(_params[0].AsString()); solves the issue

[superboyiii]

I confirmed that changing the first line of RpcServer InvokeScript to byte[] script = Convert.FromBase64String(_params[0].AsString()); solves the issue

Fixed in #386. Please have a review.