Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode scripts in base64 #337

Closed
roman-khimov opened this issue Sep 1, 2020 · 0 comments · Fixed by #362
Closed

Encode scripts in base64 #337

roman-khimov opened this issue Sep 1, 2020 · 0 comments · Fixed by #362

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
neo-project/neo#1199 changed VM script JSON representation for contract states, transactions and some other structures. But in modules we still have invokescript RPC method accepting hex-encoded scripts and all invoke* methods returning hex-encoded data in the script field. It all works just fine, but still it seems to be a little inconsistent, one representation for all cases is more convenient.

Do you have any solution you want to propose?
Change invoke* methods to work with base64-encoded scripts, both for input and output.

It may also be extended to non-verbose block/header/transaction/storage item getters, but that's more invasive and questionable.

Where in the software does this update applies to?

  • Plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant