Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationLogs serialization #318

Closed
AnnaShaleva opened this issue Aug 12, 2020 · 2 comments · Fixed by #321
Closed

ApplicationLogs serialization #318

AnnaShaleva opened this issue Aug 12, 2020 · 2 comments · Fixed by #321

Comments

@AnnaShaleva
Copy link
Member

Modules
ApplicationLogs and RPCClient Neo 3 preview 3

Describe the bug
ApplicationLogs Plugin serializes Blockchain.ApplicationExecuted.Stack as array of StackItem (here). RPCClient deserializes RpcApplicationLog.Stack as array of ContractParameter (here). So there's a mismatch between serialization formats of application logs e.g. for ByteString stackitem type and ByteArray smartcontract parameter type.

Expected behavior
It would be great to unify serialization format for application logs.

@ProDog
Copy link
Contributor

ProDog commented Aug 13, 2020

@AnnaShaleva please look #321, now to serialize by Utility.StackItemFromJson.

@AnnaShaleva
Copy link
Member Author

It's OK now, thank you for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants