Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: marshal getapplicationlog stack as []stackitem.Item #1317

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva added the rpc RPC server and client label Aug 13, 2020
@AnnaShaleva AnnaShaleva self-assigned this Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1317 into master will increase coverage by 0.00%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files         215      215           
  Lines       18508    18536   +28     
=======================================
+ Hits        12599    12619   +20     
- Misses       5227     5232    +5     
- Partials      682      685    +3     
Impacted Files Coverage Δ
pkg/rpc/response/result/application_log.go 88.00% <81.81%> (-12.00%) ⬇️
pkg/rpc/client/wsclient.go 83.22% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d86b6...0834661. Read the comment docs.

@roman-khimov roman-khimov merged commit 8da092d into master Aug 13, 2020
@roman-khimov roman-khimov deleted the rpc/getapplicationlog branch August 13, 2020 14:54
@roman-khimov roman-khimov added this to the v0.91.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants