Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications state serialization #1371

Closed
roman-khimov opened this issue Aug 27, 2020 · 0 comments · Fixed by #1387
Closed

Notifications state serialization #1371

roman-khimov opened this issue Aug 27, 2020 · 0 comments · Fixed by #1387
Assignees
Labels
rpc RPC server and client
Milestone

Comments

@roman-khimov
Copy link
Member

0834661 only changed VM stack representation, but notify events items were also changed in neo-project/neo-modules#318 and so we should adapt them too as well as our subscription-driven notifications.

The only thing suspicious here is that manifests still use smartcontract's parameters for events description, but that's probably a topic for another discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants