Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying custom hooks. Avoid breaking existing hooks #6

Merged
merged 2 commits into from
Jan 9, 2021

Conversation

kibertoad
Copy link
Contributor

fix #1
fix #3

Avoid breaking existing hooks
@codecov-io
Copy link

codecov-io commented Jan 9, 2021

Codecov Report

Merging #6 (eac5730) into master (c00291f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           18        23    +5     
=========================================
+ Hits            18        23    +5     
Impacted Files Coverage Δ
plugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00291f...eac5730. Read the comment docs.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks a lot

@simoneb simoneb merged commit 3a030d4 into nearform:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to customize which hook to attach the automatic check to Do not override route's preHandler
3 participants