Support overriding rules per route #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
commented
Jan 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 23 26 +3
=========================================
+ Hits 23 26 +3
Continue to review full report at Codecov.
|
simoneb
reviewed
Jan 9, 2021
simoneb
reviewed
Jan 9, 2021
simoneb
reviewed
Jan 9, 2021
simoneb
reviewed
Jan 9, 2021
Comment on lines
+101
to
+103
| rest: { | ||
| getObj: request => request.userId | ||
| }, |
There was a problem hiding this comment.
this new behavior of the values that casbin.rest can have should be documented in the API section of the README. It was only very briefly shown because the only supported value before was true. I saw you added it below the table of the plugin options but it's worth mentioning more explicitly above.
simoneb
approved these changes
Jan 9, 2021
simoneb
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2
Ideally should be reviewed and merged after #6 in order to reduce the amount of noise, as it buils upon it.