Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to customize which hook to attach the automatic check to #3

Closed
simoneb opened this issue Nov 6, 2020 · 1 comment · Fixed by #6
Closed

Allow user to customize which hook to attach the automatic check to #3

simoneb opened this issue Nov 6, 2020 · 1 comment · Fixed by #6

Comments

@simoneb
Copy link
Member

simoneb commented Nov 6, 2020 •
edited
Loading

Currently, preHandler is used.

A more sensible default would be onRequest, which is early enough to guarantee that no unnecessary operations are done on a request that's eventually going to be forbidden by authorization rules.

Clearly, if that becomes the default, any logic which needs to happen before authorization also needs to happen earlier in the request lifecycle. The examples and example application need to change to do authentication earlier (onRequest VS preValidation)
@kibertoad
Copy link
Contributor

Can I pick this one up?

@kibertoad kibertoad mentioned this issue Jan 9, 2021
Merged
@simoneb simoneb closed this as completed in #6 Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support specifying custom hooks. Avoid breaking existing hooks kibertoad/fastify-casbin-rest
2 participants
@simoneb @kibertoad