Merging UpStream #38

surajsahani · 2024-09-03T13:48:03Z

See the contributing readme for more detailed guideline, please understand and accept them: https://github.com/Helium314/HeliBoard/blob/main/CONTRIBUTING.md
tl;dr (you should still read the full list though):

make sure it's wanted
a single thing only
describe it properly
re-use existing mechanisms / code
low performance impact
make it a draft if you still want to work on it
no translations or dictionaries

Further

When the PR contains "fixes" , the related issue will be linked and automatically closed if the PR is merged (also works for other words like "fix", "resolve", "resolves", "closes", ...)
If you add a keyboard layout, make sure you have read https://github.com/Helium314/HeliBoard/blob/main/layouts.md#adding-new-layouts--languages
Please avoid force-pushing when doing changes. This way it's not possible which parts have changed since the previous state.

…styleable increases flexibility preparation for planned changes

Symbol `ъ` does not exist in Ukrainian language, therefore there's no need to have it on keyboard.

app still needs to be restarted when switching types workaround for #1034, but should be fixed properly at some point

fixes #1062 (also remove unused function)

fixes #1009

make it customizable later

apparently settings keys can be null

just determine json or simple when parsing fixes #1034

so users can do #558 themselves

… multilingual typing should somewhat reduce addition of unwanted words to personal dictionary when auto-add is enabled

fixes #1020

fixes #956 fixes #875 (set text to space)

…966)

Helium314 and others added 19 commits August 24, 2024 23:46

set keyboard icon ids per style in keyboardIconsSet instead of using …

aed5704

…styleable increases flexibility preparation for planned changes

allow independent selection of icon style and theme style

48b0bb1

small update to guidelines

2de5798

fix(uk): remove non-existing symbol (#1038)

7b4420c

Symbol `ъ` does not exist in Ukrainian language, therefore there's no need to have it on keyboard.

don't remove the layout when switching between text and json

c0e3811

app still needs to be restarted when switching types workaround for #1034, but should be fixed properly at some point

always add punctuation popups to non-priority popups

b43e06c

fixes #1062 (also remove unused function)

add escape to processCode

be5c86a

fixes #1009

move number row into assets

ee74802

make it customizable later

fix bad backup

a1a7489

apparently settings keys can be null

don't use json/txt file endings for custom layouts

44eb296

just determine json or simple when parsing fixes #1034

allow customizing number row

3306ffb

so users can do #558 themselves

don't show toolbar key names as popup hint labels

6f71e57

be a bit more strict when determining a clearly preferred language in…

c96326a

… multilingual typing should somewhat reduce addition of unwanted words to personal dictionary when auto-add is enabled

don't expect number row to have 10 keys

374b840

allow numpad key in custom layout

4ddfd2d

fixes #1020

allow customizing text on space bar

8ca65ae

fixes #956 fixes #875 (set text to space)

fix setting the correct script in tests

be13ca4

Replace bottom keys in emoji / clipboard view customizable keyboard (#…

ab34815

…966)

actually use downEvent detection, fixes #1075

404f6a5

surajsahani merged commit 2874e0d into navgurukul:main Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging UpStream #38

Merging UpStream #38

surajsahani commented Sep 3, 2024

Merging UpStream #38

Merging UpStream #38

Conversation

surajsahani commented Sep 3, 2024