fix(gauge): fixed wrong bottom padding calculation #1471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- from now 'isLegendRight' can be truthy only if legend is enabled
netil
pushed a commit
that referenced
this pull request
Jul 16, 2020
# [2.0.0](1.12.11...2.0.0) (2020-07-16) ### Bug Fixes * **all:** Fix test cases ([2e1ad79](2e1ad79)) * **arc:** fix applying data.labels.colors ([#1448](#1448)) ([c128fad](c128fad)), closes [#1440](#1440) * **axis:** fix incorrect clip node handling ([a8c6f96](a8c6f96)), closes [#1449](#1449) * **axis:** make axis clip-path to fit real axis size ([7419f44](7419f44)), closes [#1449](#1449) * **bar:** fix bar width scale on zoom ([59073bd](59073bd)), closes [#1476](#1476) * **data:** fix for data.labels=false ([b7a0972](b7a0972)), closes [#1444](#1444) * **data.selection:** fix selection.isselectable value check ([9d41a04](9d41a04)) * **gauge:** fixed wrong bottom padding calculation ([0542586](0542586)), closes [#1441](#1441) [#1471](#1471) * **legend:** Don't bind event when interaction is false ([4546c00](4546c00)) * **point:** Correct focus.only to work in mobile env ([67eea16](67eea16)) * **point:** Correct point.focus.only ([1686594](1686594)) * **point:** update point generation ([da63e39](da63e39)) * **subchar:** correct subchart rendering ([44ed216](44ed216)), closes [#1458](#1458) ### Code Refactoring * **all:** v2 updates ([e23998f](e23998f)), closes [#758](#758) [#757](#757) [#756](#756) [#36](#36) * **module:** implement ESM index ([85caf71](85caf71)) ### Features * **axis:** Intent to ship log scale ([6fdf3e4](6fdf3e4)), closes [#1351](#1351) * **bar:** Intent to ship bar.label.threshold ([72a7b7f](72a7b7f)), closes [#1427](#1427) * **gauge:** Intent to ship gauge.label.threshold ([#1443](#1443)) ([9a0807e](9a0807e)), closes [#1439](#1439) * **interaction:** split selection, subchart & zoom ([ba1e4f2](ba1e4f2)) * **point:** Intent to ship point.focus.only ([bb70347](bb70347)) ### BREAKING CHANGES * **all:** v2 updates * **module:** new index for ESM build - split Axis releated size from size.ts --> size.axis.ts - split common main option from Options.ts --> ./common/main.ts - Instead export Axis class, add .getAxisInstance() to make beneficial from tree-shaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1441
Details