Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subchart is not working or wrong scaled in V2.0.0-Next5 #1458

Closed
RonnyWeiss opened this issue Jun 19, 2020 · 4 comments
Closed

Subchart is not working or wrong scaled in V2.0.0-Next5 #1458

RonnyWeiss opened this issue Jun 19, 2020 · 4 comments
Labels
Milestone

Comments

@RonnyWeiss
Copy link

Hello

I tried out V2.0.0-Next5 and your last fixes work great but subcharts are not working correctly:

grafik

grafik

finalChartData is:

chartconf.txt

Hope you can fix the problem! Thank you

Kind regards

Ronny

@RonnyWeiss RonnyWeiss changed the title Subchart is not working or wrong scaled Subchart is not working or wrong scaled in V2.0.0-Next5 Jun 19, 2020
@netil netil added the bug label Jun 19, 2020
@netil netil added this to the 2.0-next milestone Jun 19, 2020
@netil
Copy link
Member

netil commented Jun 19, 2020

@RonnyWeiss, thanks for the report.
It seems having an issue related with the data.groups. I'll be dig on this.

@RonnyWeiss
Copy link
Author

Thank you will test fix again :-)

@RonnyWeiss
Copy link
Author

RonnyWeiss commented Jun 20, 2020

could you also please fix the blank spüace between the legend and the subchart? I can not set by any setting that subchart is directly above the legend? OR should I create another issue for this?

netil added a commit that referenced this issue Jun 23, 2020
- fix .isGrouped()
- specify .bb-subchart class for subchart <g> element
- fix determining Area type for subchart
- fix missing subchart param on y axis scale

Ref #1458
netil pushed a commit that referenced this issue Jun 23, 2020
# [2.0.0-next.6](2.0.0-next.5...2.0.0-next.6) (2020-06-23)

### Bug Fixes

* **subchar:** correct subchart rendering ([44ed216](44ed216)), closes [#1458](#1458)
@netil
Copy link
Member

netil commented Jun 23, 2020

@RonnyWeiss, done. Try the next.6 :)

@netil netil closed this as completed Jun 23, 2020
netil pushed a commit that referenced this issue Jul 16, 2020
# [2.0.0](1.12.11...2.0.0) (2020-07-16)

### Bug Fixes

* **all:** Fix test cases ([2e1ad79](2e1ad79))
* **arc:** fix applying data.labels.colors ([#1448](#1448)) ([c128fad](c128fad)), closes [#1440](#1440)
* **axis:** fix incorrect clip node handling ([a8c6f96](a8c6f96)), closes [#1449](#1449)
* **axis:** make axis clip-path to fit real axis size ([7419f44](7419f44)), closes [#1449](#1449)
* **bar:** fix bar width scale on zoom ([59073bd](59073bd)), closes [#1476](#1476)
* **data:** fix for data.labels=false ([b7a0972](b7a0972)), closes [#1444](#1444)
* **data.selection:** fix selection.isselectable value check ([9d41a04](9d41a04))
* **gauge:** fixed wrong bottom padding calculation ([0542586](0542586)), closes [#1441](#1441) [#1471](#1471)
* **legend:** Don't bind event when interaction is false ([4546c00](4546c00))
* **point:** Correct focus.only to work in mobile env ([67eea16](67eea16))
* **point:** Correct point.focus.only ([1686594](1686594))
* **point:** update point generation ([da63e39](da63e39))
* **subchar:** correct subchart rendering ([44ed216](44ed216)), closes [#1458](#1458)

### Code Refactoring

* **all:** v2 updates ([e23998f](e23998f)), closes [#758](#758) [#757](#757) [#756](#756) [#36](#36)
* **module:** implement ESM index ([85caf71](85caf71))

### Features

* **axis:** Intent to ship log scale  ([6fdf3e4](6fdf3e4)), closes [#1351](#1351)
* **bar:** Intent to ship bar.label.threshold ([72a7b7f](72a7b7f)), closes [#1427](#1427)
* **gauge:** Intent to ship gauge.label.threshold ([#1443](#1443)) ([9a0807e](9a0807e)), closes [#1439](#1439)
* **interaction:** split selection, subchart & zoom ([ba1e4f2](ba1e4f2))
* **point:** Intent to ship point.focus.only ([bb70347](bb70347))

### BREAKING CHANGES

* **all:** v2 updates
* **module:** new index for ESM build

- split Axis releated size from size.ts --> size.axis.ts
- split common main option from Options.ts --> ./common/main.ts
- Instead export Axis class, add .getAxisInstance() to make beneficial
  from tree-shaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants