Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: can't access property "each", $$.$el.text is null is 2.0.0-Next3 #1444

Closed
RonnyWeiss opened this issue Jun 15, 2020 · 2 comments
Closed
Labels

Comments

@RonnyWeiss
Copy link

Hello

I immediately wanted to test the new feature with the Gauges and tried the new release 2.0.0 Next3. The following error came immediately:

callstack

with following json:

chart json.txt

I follow this up to the code line and saw it was a new function:

Unbenannt

Does it need a fix or is my json wrong?

Kind regards

Ronny

@netil netil added the question label Jun 15, 2020
@netil
Copy link
Member

netil commented Jun 15, 2020

@RonnyWeiss, don't need to explicitly set data.labels option. Just removing, will work.

data: {
   "labels":false,  // remove this option
}

BTW, There's an issue where triggers this issue when set to false, I'll be fix that.

netil added a commit that referenced this issue Jun 15, 2020
Make sure to not execute .redrawText() when data.labels set to 'false'.

Ref #1444
@RonnyWeiss
Copy link
Author

You're fast! Thank you try fixed version when avail.

Kind regards

Ronny

@netil netil closed this as completed Jun 16, 2020
netil pushed a commit that referenced this issue Jun 17, 2020
# [2.0.0-next.4](2.0.0-next.3...2.0.0-next.4) (2020-06-17)

### Bug Fixes

* **arc:** fix applying data.labels.colors ([#1448](#1448)) ([c128fad](c128fad)), closes [#1440](#1440)
* **data:** fix for data.labels=false ([b7a0972](b7a0972)), closes [#1444](#1444)
* **legend:** Don't bind event when interaction is false ([4546c00](4546c00))
netil pushed a commit that referenced this issue Jul 16, 2020
# [2.0.0](1.12.11...2.0.0) (2020-07-16)

### Bug Fixes

* **all:** Fix test cases ([2e1ad79](2e1ad79))
* **arc:** fix applying data.labels.colors ([#1448](#1448)) ([c128fad](c128fad)), closes [#1440](#1440)
* **axis:** fix incorrect clip node handling ([a8c6f96](a8c6f96)), closes [#1449](#1449)
* **axis:** make axis clip-path to fit real axis size ([7419f44](7419f44)), closes [#1449](#1449)
* **bar:** fix bar width scale on zoom ([59073bd](59073bd)), closes [#1476](#1476)
* **data:** fix for data.labels=false ([b7a0972](b7a0972)), closes [#1444](#1444)
* **data.selection:** fix selection.isselectable value check ([9d41a04](9d41a04))
* **gauge:** fixed wrong bottom padding calculation ([0542586](0542586)), closes [#1441](#1441) [#1471](#1471)
* **legend:** Don't bind event when interaction is false ([4546c00](4546c00))
* **point:** Correct focus.only to work in mobile env ([67eea16](67eea16))
* **point:** Correct point.focus.only ([1686594](1686594))
* **point:** update point generation ([da63e39](da63e39))
* **subchar:** correct subchart rendering ([44ed216](44ed216)), closes [#1458](#1458)

### Code Refactoring

* **all:** v2 updates ([e23998f](e23998f)), closes [#758](#758) [#757](#757) [#756](#756) [#36](#36)
* **module:** implement ESM index ([85caf71](85caf71))

### Features

* **axis:** Intent to ship log scale  ([6fdf3e4](6fdf3e4)), closes [#1351](#1351)
* **bar:** Intent to ship bar.label.threshold ([72a7b7f](72a7b7f)), closes [#1427](#1427)
* **gauge:** Intent to ship gauge.label.threshold ([#1443](#1443)) ([9a0807e](9a0807e)), closes [#1439](#1439)
* **interaction:** split selection, subchart & zoom ([ba1e4f2](ba1e4f2))
* **point:** Intent to ship point.focus.only ([bb70347](bb70347))

### BREAKING CHANGES

* **all:** v2 updates
* **module:** new index for ESM build

- split Axis releated size from size.ts --> size.axis.ts
- split common main option from Options.ts --> ./common/main.ts
- Instead export Axis class, add .getAxisInstance() to make beneficial
  from tree-shaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants